Bug #58352

Invalid localization overlay of cObject FILES

Added by Oliver Hader about 7 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2014-04-30
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
medium
Is Regression:
No
Sprint Focus:

Description

The TypoScript cObject FILES does not consider localization overlays and behavior correctly:
  • l10n_mode is not considered
  • additional translation table (e.g. for pages) is not considered correctly

Related issues

Related to TYPO3 Core - Bug #57488: page record overlays: media field not translatableClosedOliver Hader2014-04-01

Actions
Related to TYPO3 Core - Bug #47869: Failed localization of FILES content object related to pagesClosedEugene Skomorokhov2013-05-03

Actions
Related to TYPO3 Core - Bug #48113: typoscript FILES object always uses default language when accessing page resource images of translated images Closed2013-05-11

Actions
Related to TYPO3 Core - Bug #57272: Extbase doesn't handle FAL translations correctlyClosed2014-03-25

Actions
Related to TYPO3 Core - Bug #59192: mergeIfNotBlank with FAL recordsClosed2014-05-28

Actions
Related to TYPO3 Core - Bug #60998: PageRepository::shouldFieldBeOverlaid raises PHP warningClosed2014-08-15

Actions
Related to TYPO3 Core - Bug #65863: content_fallback / mergeIfNotblank fails with content slide, pageOverlayFields is ignoredClosedJo Hasenau2015-03-20

Actions
#1

Updated by Gerrit Code Review about 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29739

#2

Updated by Oliver Hader about 7 years ago

How to test the patch:

Requirements:
  • open typo3conf/extTables.php and put
    $GLOBALS['TCA']['pages_language_overlay']['columns']['media']['l10n_mode'] = 'mergeIfNotBlank';
  • clear TCA caches (e.g. "clear all" in Install Tool)
  • create translation of a page, without translating the media field (on the resources tab)
  • have some TypoScript to out the file or the name of the file, e.g.
    @page = PAGE
    page.10 = FILES
    1. page.10.references = ...
      page.10.renderObj = TEXT
      page.10.renderObj.data = file:current:publicUrl
      page.10.renderObj.wrap = |,

Tests:
1) TypoScript using the special "fieldName" property
page.10.references.fieldName = media

2) TypoScript using stdWrap
page.10.references.field = media

#3

Updated by Frans Saris about 7 years ago

@Olly:
This doesn't work:

page.10.references.field = media

In handleFileReferences() you explicit look for fieldName or else there is a early return.

#4

Updated by Gerrit Code Review about 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29739

#5

Updated by Gerrit Code Review about 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29739

#6

Updated by Gerrit Code Review about 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29739

#7

Updated by Gerrit Code Review about 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29739

#8

Updated by Gerrit Code Review about 7 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29739

#9

Updated by Gerrit Code Review about 7 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29739

#10

Updated by Gerrit Code Review about 7 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29739

#11

Updated by Tymoteusz Motylewski about 7 years ago

should be resolved with https://review.typo3.org/29739

#12

Updated by Steffen Ritter about 7 years ago

  • Status changed from Under Review to Resolved
#13

Updated by Gerrit Code Review about 7 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30666

#14

Updated by Gerrit Code Review about 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30666

#15

Updated by Gerrit Code Review about 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30666

#16

Updated by Steffen Ritter about 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#17

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF