Task #58475

Epic #55575: Streamline JavaScript Code in the TYPO3 Backend

Feature #39721: Remove Prototype and script.aculo.us JavaScript libraries

Change IRRE Javascript code to jQuery

Added by Andreas Wolf over 5 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Backend User Interface
Target version:
Start date:
2014-05-04
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
medium
Sprint Focus:

Description

The IRRE Javascript code still uses Prototype, which should be replaced with jQuery. Beforehand, the code should be reformatted to match coding guidelines.


Related issues

Related to TYPO3 Core - Task #59670: Cleanup jsfunc.inline.js Closed 2014-06-19
Related to TYPO3 Core - Task #55572: Switch IRRE to jQuery Closed 2014-02-02
Related to TYPO3 Core - Bug #62001: [Regression] Can not add image to FAL field in Flexform Closed 2014-10-02
Related to TYPO3 Core - Bug #62440: RTE is not loaded when creating new child or when all children are collapsed Closed 2014-10-24

Associated revisions

Revision ebfd4674 (diff)
Added by Andreas Wolf over 5 years ago

[CLEANUP] Reformat IRRE JS code

This is an automatic reformat performed by PhpStorm, to get rid of some
ugly constructs like one-line inline methods.

Change-Id: Id24666c673b3822916f9c5233c0b34ce7d38e7aa
Related: #58475
Releases: 6.3
Reviewed-on: https://review.typo3.org/29833
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

Revision 8eb77ff1 (diff)
Added by Andreas Wolf over 5 years ago

[TASK] Use jQuery for IRRE Ajax calls

Change-Id: I5fe2f79ba233e114fb2bfb87c1100eeb8dccbc41
Resolves: #58475
Releases: 6.3
Reviewed-on: http://review.typo3.org/29835
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision cb6b7f51 (diff)
Added by Andreas Wolf over 5 years ago

[TASK] Replace Prototype in inline record JS

This is the first step of replacing Prototype usage.

Change-Id: I6599c3ce7eea493e2bfaa29312775bf1659ded69
Resolves: #58475
Releases: 6.3
Reviewed-on: http://review.typo3.org/29834
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision 0a578709 (diff)
Added by Tymoteusz Motylewski over 5 years ago

[BUGFIX] Make FAL work in the flexform field having dot in the name

Fixes regression introduced in I6599c3ce7eea493e2bfaa29312775bf1659ded69
During the change from prototype to jQuery few places missed
escaping of the dot in the id of the DOM node.

This patch fixes these places and also few other jQuery related bugs
E.g. we have to use "object.length" to test if jQuery selector
was found.

Resolves: #62001
Related: #58475
Releases: master
Change-Id: I9bb661c5bf58aa9b73106a1e48f2206465a8974e
Reviewed-on: http://review.typo3.org/33106
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision e451a415 (diff)
Added by Andreas Wolf about 5 years ago

[CLEANUP] Simplify method structures in IRRE JS

There were some deeply nested if-structures in the IRRE JS code, which
are replaced with guard clauses with early returns in this commit.

Change-Id: I8d16b1860679b96ce20a7f484bcccb5a1d395091
Related: #58475
Releases: master
Reviewed-on: http://review.typo3.org/29836
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Stefan Neufeind <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>

History

#1 Updated by Stefan Neufeind over 5 years ago

One partial solution is currently under review:
[TASK] Use jQuery for IRRE Ajax calls
https://review.typo3.org/29835

#2 Updated by Stefan Neufeind over 5 years ago

Some hint to lookup what all those $A etc. in prototype are for: :-)
http://prototypejs.org/doc/latest/language/dollar-A/

#3 Updated by Stefan Neufeind over 5 years ago

There is a review in ticket #55572 meanwhile. I guess we can close this one and continue in the other ticket?

#4 Updated by Markus Klein over 5 years ago

I blocked #55572 until this is done.

#5 Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/29834

#6 Updated by Gerrit Code Review over 5 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/29835

#7 Updated by Andreas Wolf over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Stanislas Rolland about 5 years ago

  • Status changed from Resolved to New

This change breaks the RTE. See #62440

See comment on https://review.typo3.org/#/c/29834/7

#9 Updated by Mathias Schreiber about 5 years ago

  • Target version changed from 7.0 to 7.1 (Cleanup)

#10 Updated by Stefan Neufeind about 5 years ago

Do I see right this issue might have been addressed meanwhile, but problems that resulted from this change are still being fixed/patches reviewed? They have separate forge-issues though.

#11 Updated by Benni Mack almost 5 years ago

  • Status changed from New to Resolved

done!

#12 Updated by Riccardo De Contardi over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF