Project

General

Profile

Actions

Bug #59133

closed

Error while converting RTE enabled fields to FAL

Added by Tizian Schmidlin over 10 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Install Tool
Target version:
Start date:
2014-05-27
Due date:
% Done:

100%

Estimated time:
0.50 h
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

When converting files from RTE to FAL, I got several issues stating that probably the reference index was out of date.

Actually, the problem came from the generation of the regular expression in RteFileLinksUpdateWizard (see also #51800).

This is what the regex used to look like before:

$regularExpression = '$<(link ' . str_replace(' ', '%20', $reference['ref_string']) . ').*>$';

Basically it replaced the whitespaces with %20. The reason, why urlencode was not used here is obvious but it still should have been considered to use it, I think.

This is how it worked for me in the end:

$regularExpression = '$<(link ' . str_replace('%2F','/',urlencode($reference['ref_string'])) . ').*>$';

This way you resolve any issues with german specialchars that are savec urlencoded in the database.

Regards
Tizian


Files

dump.sql (12.1 KB) dump.sql Christian Nölle, 2014-07-31 14:36
patch_62307.diff (816 Bytes) patch_62307.diff Helmut Hummel, 2014-10-24 10:20

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #51800: 6.1.4 Update wizard fails at step "Migrate all file links of RTE-enabled fields to FAL" for pdf documentsClosed2013-09-06

Actions
Has duplicate TYPO3 Core - Bug #62307: RteFileLinksUpdateWizard.php only handles spaces, no other 'special' charactersClosed2014-10-17

Actions
Actions #1

Updated by Markus Klein over 10 years ago

Can you please post samples of you DB-content here, so we can reproduce this.

Actions #2

Updated by Christian Nölle over 10 years ago

Got that problem as well, I had filenames from 4.5 that contained ÖÄÜ, those were not ported by the update wizard. After changing that line as proposed above, those files were properly transformed. Still having troubles with records that were deleted, the wizard fails on fixing those.

What kind of db dump would you need to dig further into this?

Actions #3

Updated by Markus Klein over 10 years ago

Some records of the tt_content table which contain those umlauts would be interesting.

Actions #4

Updated by Christian Nölle over 10 years ago

You got dump... ;)

Actions #5

Updated by Christian Nölle over 10 years ago

Actions #6

Updated by Christian Nölle over 10 years ago

Can anybody approve/accept this? In our bigger installations we end up with +2.000 links that can not be converted...

Actions #7

Updated by Christian Nölle over 10 years ago

Besides the problems with german umlauts on that update wizard it seems, that the wizard is trying to fix deleted tt_content items as well. No need for that, as it provokes errors: Content gets deleted, file is geting deleted from filelist, wizards tries to fix that link, file not present anymore, error... :/

Actions #8

Updated by Markus Klein over 10 years ago

Well we need to convert deleted tt_content as well, because if you recover the deleted item the images must have a correct reference.

Actions #9

Updated by Helmut Hummel over 10 years ago

Christian Nölle wrote:

Got that problem as well, I had filenames from 4.5 that contained ÖÄÜ, those were not ported by the update wizard.

So you had [SYS][UTF8filesystem] enabled in your installation?

Actions #10

Updated by Helmut Hummel over 10 years ago

Markus Klein wrote:

Well we need to convert deleted tt_content as well, because if you recover the deleted item the images must have a correct reference.

If looking at deleted tt_content elements causes problems, we cannot solve (haven't looked into it yet), then we should rather ignore the edge case that people may recover deleted records. In fact I would recommend to remove all deleted records before an upgrade anyway (using lowlevel cleaner)

Actions #11

Updated by Christian Nölle over 10 years ago

Helmut Hummel wrote:

Christian Nölle wrote:

Got that problem as well, I had filenames from 4.5 that contained ÖÄÜ, those were not ported by the update wizard.

So you had [SYS][UTF8filesystem] enabled in your installation?

Yes. We have.

Actions #12

Updated by Helmut Hummel about 10 years ago

Add patch from duplicate ticket

Actions #13

Updated by Gerrit Code Review about 10 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33624

Actions #14

Updated by Gerrit Code Review about 10 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33976

Actions #15

Updated by Gerrit Code Review about 10 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33976

Actions #16

Updated by jo about 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #17

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF