Bug #59133
closed
Error while converting RTE enabled fields to FAL
100%
Description
When converting files from RTE to FAL, I got several issues stating that probably the reference index was out of date.
Actually, the problem came from the generation of the regular expression in RteFileLinksUpdateWizard (see also #51800).
This is what the regex used to look like before:
$regularExpression = '$<(link ' . str_replace(' ', '%20', $reference['ref_string']) . ').*>$';
Basically it replaced the whitespaces with %20. The reason, why urlencode was not used here is obvious but it still should have been considered to use it, I think.
This is how it worked for me in the end:
$regularExpression = '$<(link ' . str_replace('%2F','/',urlencode($reference['ref_string'])) . ').*>$';
This way you resolve any issues with german specialchars that are savec urlencoded in the database.
Regards
Tizian
Files
Updated by Markus Klein almost 10 years ago
Can you please post samples of you DB-content here, so we can reproduce this.
Updated by Christian Nölle over 9 years ago
Got that problem as well, I had filenames from 4.5 that contained ÖÄÜ, those were not ported by the update wizard. After changing that line as proposed above, those files were properly transformed. Still having troubles with records that were deleted, the wizard fails on fixing those.
What kind of db dump would you need to dig further into this?
Updated by Markus Klein over 9 years ago
Some records of the tt_content table which contain those umlauts would be interesting.
Updated by Christian Nölle over 9 years ago
Can anybody approve/accept this? In our bigger installations we end up with +2.000 links that can not be converted...
Updated by Christian Nölle over 9 years ago
Besides the problems with german umlauts on that update wizard it seems, that the wizard is trying to fix deleted tt_content items as well. No need for that, as it provokes errors: Content gets deleted, file is geting deleted from filelist, wizards tries to fix that link, file not present anymore, error... :/
Updated by Markus Klein over 9 years ago
Well we need to convert deleted tt_content as well, because if you recover the deleted item the images must have a correct reference.
Updated by Helmut Hummel over 9 years ago
Christian Nölle wrote:
Got that problem as well, I had filenames from 4.5 that contained ÖÄÜ, those were not ported by the update wizard.
So you had [SYS][UTF8filesystem] enabled in your installation?
Updated by Helmut Hummel over 9 years ago
Markus Klein wrote:
Well we need to convert deleted tt_content as well, because if you recover the deleted item the images must have a correct reference.
If looking at deleted tt_content elements causes problems, we cannot solve (haven't looked into it yet), then we should rather ignore the edge case that people may recover deleted records. In fact I would recommend to remove all deleted records before an upgrade anyway (using lowlevel cleaner)
Updated by Christian Nölle over 9 years ago
Helmut Hummel wrote:
Christian Nölle wrote:
Got that problem as well, I had filenames from 4.5 that contained ÖÄÜ, those were not ported by the update wizard.
So you had [SYS][UTF8filesystem] enabled in your installation?
Yes. We have.
Updated by Helmut Hummel over 9 years ago
- File patch_62307.diff patch_62307.diff added
- Status changed from New to Accepted
Add patch from duplicate ticket
Updated by Gerrit Code Review over 9 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33624
Updated by Gerrit Code Review over 9 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33976
Updated by Gerrit Code Review over 9 years ago
Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33976
Updated by jo over 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 7140e80de79b8220130570055ef0971a00dc0ec6.
Updated by