Bug #60995
closedEpic #69036: EXT:form - Optimize layout rendering
tx_form PostProcessor - wrong layout handling
Added by Ralf Zimmermann over 10 years ago. Updated about 6 years ago.
100%
Description
There are some changes applied in changeset https://forge.typo3.org/projects/typo3cms-core/repository/revisions/8bd1988d82256c1851b426e1e86b04c308a3b50f
Now you can assign a layout via Typoscript to the postProcessor section, look @ #31951#note-15
The current code works with a Typoscript like
postProcessor { mail { layout { ... } }
but the correct synthax is
postProcessor { 1 = mail 1 { layout { ... } } }
Classes/PostProcess/PostProcessor.php don't handle that correctly.
Look at the attached patch.
Files
PostProcessor.php.diff (858 Bytes) PostProcessor.php.diff | Ralf Zimmermann, 2014-08-15 14:24 |
Updated by Gerrit Code Review almost 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35219
Updated by Gerrit Code Review almost 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35219
Updated by Björn Jacob over 9 years ago
- Category changed from Form Framework to 1602
Updated by Björn Jacob over 9 years ago
- Category changed from 1602 to Form Framework
Updated by Gerrit Code Review over 9 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42607
Updated by Ralf Zimmermann over 9 years ago
I would like to describe the problem a little better.
With this patch
is it possible to add a global layout to the postProcessor section.
postProcessor { layout.label = <div><labelvalue /></div> ... }
But is it not possible to add a layout to a specific postProcessor.
postProcessor { 1 = mail 1 { recipientEmail = xy@example.com senderEmail = xy@example.com layout.label = <div><labelvalue /></div> } }
The behaviour should be like this:
- If a single postProcessor has a "layout" section - use this.
- If a single postProcessor has no "layout" section, but the global postProcessor section has a "layout" section - use this.
My previous patchset 2 was incomplete
Look at how behaves tx_form with and without old and new patch:
postProcessor { layout.label = <div><labelvalue /></div> 1 = mail 1 { recipientEmail = xy@example.com senderEmail = xy@example.com } }
without old patchset 2 :
Mail: <div>Name</div> <- global processor label layout is used / OK
with old patchset 2 :
Mail: <em>Name</em> <- single processor label layout is used / NOT OK
postProcessor { 1 = mail 1 { recipientEmail = xy@example.com senderEmail = xy@example.com layout.label = <div><labelvalue /></div> } }
without old patchset 2 :
Mail: <em>Name</em> <- global processor label layout is used / NOT OK
with old patchset 2 :
Mail: <div>Name</div> <- single processor label layout is used / OK
postProcessor { layout.label = <b><labelvalue /></b> 1 = mail 1 { recipientEmail = xy@example.com senderEmail = xy@example.com } }
without new patchset 3 :
Mail: <b>Name</b> <- global processor label layout is used / OK
with new patchset 3 :
Mail: <b>Name</b> <- global processor label layout is used / OK
postProcessor { layout.label = <b><labelvalue /></b> 1 = mail 1 { recipientEmail = xy@example.com senderEmail = xy@example.com layout { label = <div><labelvalue /></div> } } }
without new patchset 3 :
Mail: <b>Name</b> <- global processor label layout is used / NOT OK
with new patchset 3 :
Mail: <div>Name</div> <- single processor label layout is used / OK
Updated by Gerrit Code Review over 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35219
Updated by Gerrit Code Review about 9 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35219
Updated by Björn Jacob about 9 years ago
Tested it with the following snippet. To test the fallback process/ backward compatibility comment out the different layout.label settings.
enctype = multipart/form-data method = post prefix = tx_form confirmation = 1 postProcessor { layout.label = <div class="global"><labelvalue /></div> 1 = mail 1 { layout.label = <div class="local"><labelvalue /></div> recipientEmail = your@email.com senderEmail = your@email.com } } 10 = TEXTLINE 10 { name = surname label { value = Surname } } 20 = SUBMIT 20 { name = submit value = submit }
Updated by Gerrit Code Review about 9 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35219
Updated by Gerrit Code Review about 9 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35219
Updated by Gerrit Code Review about 9 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35219
Updated by Gerrit Code Review about 9 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35219
Updated by Gerrit Code Review about 9 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35219
Updated by Gerrit Code Review about 9 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35219
Updated by Ralf Zimmermann about 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset ff6748ae7f416ea990a6c6bba83e6456cfcd25da.
Updated by Gerrit Code Review about 9 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42926
Updated by Gerrit Code Review about 9 years ago
Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42926
Updated by Gerrit Code Review about 9 years ago
Patch set 3 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42926
Updated by Oliver Hader about 9 years ago
- Status changed from Under Review to Resolved