Bug #67402

Document "__wakeup" no longer called in AbstractDomainObjects as breaking (?)

Added by Christian Kuhn over 5 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
Start date:
2015-06-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
Stabilization Sprint

Description

with the instantiator patch __wakeup() is no longer called on re-constituting AbstractDomainModel objects from db. This might be breaking ... also, the default implementation __wakeup and the empty initializeObject() in

https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/extbase/Classes/DomainObject/AbstractDomainObject.php#L69

are obsolete. In case we decide to remove _wakeup() altogether (probably a good idea), any own __wakeup() method implementation extending AbstractDomainObject will fatal in case it calls parent::_wakeup as documented currently. This would be a breaking change then and should be documented accordingly.


Related issues

Related to TYPO3 Core - Bug #66473: Cannot create object implementing Serializable on PHP 5.6ClosedMathias Brodala2015-04-17

Actions
Related to TYPO3 Core - Bug #61044: AbstractDomainObject::__wakeup() method should not call initializeObject method internallyClosedDaniel Hürtgen2014-08-18

Actions
#1

Updated by Christian Kuhn over 5 years ago

for 7 only, for now - 6.2 may need a different approach and hopefully we manage to fix #67274 and #66473 without being breaking about __wakeup in any way ...

#2

Updated by Frank Naegler over 5 years ago

Possible solution could be to deprecate the __wakeup method, this would prevent the fatal.

#3

Updated by Christian Kuhn over 5 years ago

  • Assignee set to Christian Kuhn

taking care of this now.

#4

Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40245

#5

Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40245

#6

Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40245

#7

Updated by Gerrit Code Review over 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40245

#8

Updated by Christian Kuhn over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#9

Updated by Riccardo De Contardi about 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF