Bug #66473

Cannot create object implementing Serializable on PHP 5.6

Added by Mathias Brodala over 6 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Must have
Category:
Extbase
Target version:
Start date:
2015-04-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
5.6
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
Stabilization Sprint

Description

Starting with PHP 5.6 classes implementing the Serializable interface are represented as C instead of O in the serialized output.

The Container::getEmptyObject method which creates objects with the unserialize hack to avoid calling the constructor thus yields an error like this:

Warning: Erroneous data format for unserializing 'Foo' in ...
Notice: unserialize(): Error at offset 13 of 15 bytes in ...

Starting with PHP 5.4 this usecase can be dealt with by ReflectionClass::newInstanceWithoutConstructor

This also needs to fixed for TYPO3 6.2 though which supports PHP 5.3, in which case checking for the Serializable interface and using C instead of O could work.


Related issues

Related to TYPO3 Core - Bug #66468: TYPO3 6.2 will live longer than PHP 5.5 but is not compatible with PHP 5.6Rejected2015-04-17

Actions
Related to TYPO3 Core - Task #66911: Travis: Verify no git submodule existsClosed2015-05-12

Actions
Related to TYPO3 Core - Bug #67272: initializeObject() not called for Extbase Domain ModelClosed2015-06-03

Actions
Related to TYPO3 Core - Bug #67402: Document "__wakeup" no longer called in AbstractDomainObjects as breaking (?)ClosedChristian Kuhn2015-06-10

Actions
Related to TYPO3 Core - Bug #67408: Nail down php 5.6 instantiation issues in testsClosed2015-06-11

Actions
Related to TYPO3 Core - Bug #66482: Extbase persistence layer fails to create empty objects in PHP 5.6.Closed2015-04-19

Actions
Related to TYPO3 Core - Task #72112: travis-ci: PHP 5.6 not allowed_failure anymoreClosed2015-12-08

Actions
#1

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38765

#2

Updated by Mathias Brodala over 6 years ago

See also this change in phpunit for a few caveats.

#3

Updated by Mathias Brodala over 6 years ago

Maybe we should use doctrine/instantiator since apparently there are even more issues with this.

#4

Updated by Helmut Hummel over 6 years ago

Mathias Brodala wrote:

Maybe we should use "doctrine/instantiator"

Yes, please!

#5

Updated by Gerrit Code Review about 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38765

#6

Updated by Gerrit Code Review about 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38765

#7

Updated by Gerrit Code Review about 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38765

#8

Updated by Gerrit Code Review about 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38765

#9

Updated by Mathias Brodala about 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#10

Updated by Christian Kuhn about 6 years ago

  • Status changed from Resolved to Accepted
  • Target version changed from next-patchlevel to 6.2.13

master merged, now waiting for 6.2 backport.

#11

Updated by Gerrit Code Review about 6 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39377

#12

Updated by Gerrit Code Review about 6 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39377

#13

Updated by Gerrit Code Review about 6 years ago

Patch set 3 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39377

#14

Updated by Gerrit Code Review about 6 years ago

Patch set 4 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39377

#15

Updated by Mathias Brodala about 6 years ago

  • Status changed from Under Review to Resolved
#16

Updated by Michael Stucki about 6 years ago

  • Status changed from Resolved to Accepted
  • % Done changed from 100 to 50

This change contains an error for TYPO3_6-2, see https://review.typo3.org/#/c/39390/

After discussion with Lolli, I have reverted the change until this is fixed properly...

#17

Updated by Gerrit Code Review about 6 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39392

#18

Updated by Gerrit Code Review about 6 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39392

#19

Updated by Gerrit Code Review about 6 years ago

Patch set 3 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39392

#20

Updated by Gerrit Code Review about 6 years ago

Patch set 4 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39392

#21

Updated by Gerrit Code Review about 6 years ago

Patch set 5 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39392

#22

Updated by Gerrit Code Review about 6 years ago

Patch set 6 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39392

#23

Updated by Gerrit Code Review about 6 years ago

Patch set 7 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39392

#24

Updated by Gerrit Code Review about 6 years ago

Patch set 8 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39392

#25

Updated by Helmut Hummel about 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 50 to 100
#26

Updated by Alexander Opitz about 6 years ago

  • Status changed from Resolved to In Progress
  • Target version changed from 6.2.13 to 6.2.14

Was reverted in https://review.typo3.org/#/c/40133/ so reopen.

#27

Updated by Alexander Opitz about 6 years ago

  • Target version changed from 6.2.14 to 6.2.15
#28

Updated by Christian Kuhn almost 6 years ago

  • Sprint Focus set to Stabilization Sprint
#29

Updated by Mathias Bruckmoser almost 6 years ago

6.2.15 Released today.
Is it fixed or not?

#30

Updated by Alexander Opitz almost 6 years ago

  • Target version changed from 6.2.15 to 6.2.16

No it wasn't fixed.

#31

Updated by Gerrit Code Review over 5 years ago

  • Status changed from In Progress to Under Review

Patch set 8 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/40522

#32

Updated by Gerrit Code Review over 5 years ago

Patch set 9 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/40522

#33

Updated by Gerrit Code Review over 5 years ago

Patch set 10 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/40522

#34

Updated by Helmut Hummel over 5 years ago

  • Status changed from Under Review to Resolved
#35

Updated by Riccardo De Contardi over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF