Bug #67402
closed
Document "__wakeup" no longer called in AbstractDomainObjects as breaking (?)
Added by Christian Kuhn about 9 years ago.
Updated almost 7 years ago.
Sprint Focus:
Stabilization Sprint
Description
with the instantiator patch __wakeup() is no longer called on re-constituting AbstractDomainModel objects from db. This might be breaking ... also, the default implementation __wakeup and the empty initializeObject() in
https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/extbase/Classes/DomainObject/AbstractDomainObject.php#L69
are obsolete. In case we decide to remove _wakeup() altogether (probably a good idea), any own __wakeup() method implementation extending AbstractDomainObject will fatal in case it calls parent::_wakeup as documented currently. This would be a breaking change then and should be documented accordingly.
for 7 only, for now - 6.2 may need a different approach and hopefully we manage to fix #67274 and #66473 without being breaking about __wakeup in any way ...
Possible solution could be to deprecate the __wakeup method, this would prevent the fatal.
- Assignee set to Christian Kuhn
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40245
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40245
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40245
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40245
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
- Status changed from Resolved to Closed
Also available in: Atom
PDF