Bug #67402: Document "__wakeup" no longer called in AbstractDomainObjects as breaking (?) - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #67402

closed

Document "__wakeup" no longer called in AbstractDomainObjects as breaking (?)

Added by Christian Kuhn over 9 years ago. Updated about 7 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Christian Kuhn

Category:

Target version:

7.3 (Packages)

Start date:

2015-06-10

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Stabilization Sprint

Description

with the instantiator patch __wakeup() is no longer called on re-constituting AbstractDomainModel objects from db. This might be breaking ... also, the default implementation __wakeup and the empty initializeObject() in

https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/extbase/Classes/DomainObject/AbstractDomainObject.php#L69

are obsolete. In case we decide to remove _wakeup() altogether (probably a good idea), any own __wakeup() method implementation extending AbstractDomainObject will fatal in case it calls parent::_wakeup as documented currently. This would be a breaking change then and should be documented accordingly.

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Christian Kuhn over 9 years ago

for 7 only, for now - 6.2 may need a different approach and hopefully we manage to fix #67274 and #66473 without being breaking about __wakeup in any way ...

Actions

Copy link

Updated by Frank Nägler over 9 years ago

Possible solution could be to deprecate the __wakeup method, this would prevent the fatal.

Actions

Copy link

Updated by Christian Kuhn over 9 years ago

Assignee set to Christian Kuhn

taking care of this now.

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40245

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40245

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40245

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40245

Actions

Copy link