Bug #70918

Story #69617: FormEngine bugs

Adding inline relations in FlexForms is broken

Added by Felix Rauch over 5 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2015-10-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

This bug was introduced with #70490, https://review.typo3.org/#/c/43755/ .

Given a field of type inline in a plugin's FlexForm, creating IRRE child records fails with status code 500 Internal Server Error.

#1437654409: No $tableName given

InvalidArgumentException thrown in file
/opt/typo3_src-master/typo3/sysext/backend/Classes/Form/FormDataCompiler.php in line 81.

I attached the full stacktrace.

Going back before commit efa8c85, this does not happen.


Files

sadness.html (8 KB) sadness.html Felix Rauch, 2015-10-21 16:44
fix.patch (1.38 KB) fix.patch Nikolas Hagelstein, 2016-09-20 17:22

Related issues

Related to TYPO3 Core - Task #70490: FormEngine inline refactoringClosed2015-10-08

Actions
Related to TYPO3 Core - Bug #68045: Inline add of FAL images in flexform does not workClosed2015-07-10

Actions
Related to TYPO3 Core - Bug #71436: Inline in flex with multiple DS failsClosed2015-11-09

Actions
Has duplicate TYPO3 Core - Bug #71413: FormInlineAjaxController::create should set inlineParent values in childClosedSebastian Fischer2015-11-08

Actions
#1

Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44614

#2

Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44614

#3

Updated by Morton Jonuschat over 5 years ago

  • Parent task set to #69617
#4

Updated by Gerrit Code Review over 5 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44579

#5

Updated by Gerrit Code Review over 5 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44579

#6

Updated by Felix Rauch over 5 years ago

Not sure if this belongs here, I've been testing patch set 8 of https://review.typo3.org/44579 and am still getting a 500 Internal Server Error when creating new relations.

Configuration retrieved from FlexForm is incomplete or not of type "inline".

This is the field's config, I don't know how it is incomplete:

<settings.boxBackground>
    <TCEforms>
        <label>Lorem</label>
        <config>
            <type>inline</type>
            <maxitems>1</maxitems>
            <foreign_table>sys_file_reference</foreign_table>
            <foreign_field>uid_foreign</foreign_field>
            <foreign_table_field>tablenames</foreign_table_field>
            <foreign_label>uid_local</foreign_label>
            <foreign_sortby>sorting_foreign</foreign_sortby>
            <foreign_selector>uid_local</foreign_selector>
            <foreign_selector_fieldTcaOverride type="array">
                <config>
                    <appearance>
                        <elementBrowserType>file</elementBrowserType>
                        <elementBrowserAllowed>jpg,png</elementBrowserAllowed>
                    </appearance>
                </config>
            </foreign_selector_fieldTcaOverride>
            <foreign_match_fields type="array">
                <fieldname>box_background</fieldname>
            </foreign_match_fields>
            <appearance type="array">
                <newRecordLinkAddTitle>1</newRecordLinkAddTitle>
                <headerThumbnail>
                    <field>uid_local</field>
                    <height>64</height>
                    <width>64</width>
                </headerThumbnail>
            </appearance>
        </config>
    </TCEforms>
</settings.boxBackground>
#7

Updated by Felix Rauch over 5 years ago

Some more information: Debugging shows that $parentConfig in FormInlineAjaxController->getParentConfigFromFlexForm does not contain my actual flexform, but only the tt_content default flexform config (with the only field being <xmlTitle>).

#8

Updated by Christian Kuhn over 5 years ago

Felix, i can confirm your issue by thinking, but this is not trivial to solve. we'll probably merge the patch as is to mitigate the flex-inline problem for now and will extract your 'flex-inline-with-multiple-flex-ds-defined' to an own issue that will be handled after release.

#9

Updated by Gerrit Code Review over 5 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44579

#10

Updated by Morton Jonuschat over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#11

Updated by Wolfram Eberius over 5 years ago

Hi,

I'm not sure whether to comment here or https://forge.typo3.org/issues/71436#note-26 on that...seems not to be resolved on 7.6.2 or am I missing something?

#12

Updated by David Voigt about 5 years ago

I'm experiencing this issue in TYPO3 7.6.4, too. This core patch fixed the issue for me (don't forget to patch fluidcontent, too. Link is included in this page):
http://p.cweiske.de/270

#13

Updated by Nikolas Hagelstein over 4 years ago

David Voigt wrote:

I'm experiencing this issue in TYPO3 7.6.4, too. This core patch fixed the issue for me (don't forget to patch fluidcontent, too. Link is included in this page):
http://p.cweiske.de/270

Not really ;) Of course $databaseRow need to be fetched correctly in detailAction as well. Otherwise ur not able open the image.
Find patch attached.

Cheers,
Nikolas

#14

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF