Project

General

Profile

Actions

Bug #71843

closed

forceAbsoluteUrl has no effect

Added by Harald no-lastname-given over 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Category:
-
Start date:
2015-11-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
5.6
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

In the current development version 7.6.1.dev, works setting

typolink.forceAbsoluteUrl = 1

only on the local server installation.

The output in the source code is right here:
http://www.example.com/index.php?id=1

But at the same configuration of the online server, the output is not the domain or baseurl

The output is incomplete here:
index.php? id = 1

Many thanks

Harald


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Task #71690: Code-cleanup for ContentObjectRendererClosedStefan Neufeind2015-11-19

Actions
Has duplicate TYPO3 Core - Bug #71850: typolink.forceAbsoluteUrl doesn't force absolute urlClosed2015-11-26

Actions
Actions #1

Updated by Mathias Schreiber over 8 years ago

  • Status changed from New to Needs Feedback
  • Assignee set to Mathias Schreiber
  • Target version changed from 7.6.1 to Candidate for patchlevel

can you add a domain record and try again please?

Actions #2

Updated by Harald no-lastname-given over 8 years ago

That's what I've tried. Has changed nothing!
As already said. In version 7.6.0 this error does not occur

Actions #3

Updated by Wouter Wolters over 8 years ago

  • Status changed from Needs Feedback to Accepted

Sebastian Michaelsen wrote:

This is were it broke: https://github.com/TYPO3/TYPO3.CMS/commit/dacd79bc67c814a4f622dc6bd299ceb521aa325f#diff-fb30f860811e026eb162ad4095fa44e4R6692

parse_url() doesn't always return a host. With the weak comparison it matched the empty string.

Should be something like:

if (!isset($urlParts['host']) || $urlParts['host'] === '') {

Actions #4

Updated by Harald no-lastname-given over 8 years ago

Unfortunately, I understand PHP too little.

I have the modified "ContentObjectRenderer.php" tried or overwrite the original file.

But this has no effect on the online server version. The URL is not complete. So without baseurl.

But probably all still in progress and not yet completed.

Thank you

Harald

Actions #5

Updated by Sebastian Michaelsen over 8 years ago

I'll create a patch now

Actions #6

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44972

Actions #7

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44972

Actions #8

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44972

Actions #9

Updated by Anonymous over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Harald no-lastname-given over 8 years ago

I can only say, perfect!

thank you

Actions #11

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF