Bug #78134
closed
config.noScaleUp no longer works
100%
Description
Problem/Description¶
TypoScript config.noScaleUp no longer works since:
Commit 1f4b97454d05d7cb1be2a78b6a6e9f8fad736942
https://review.typo3.org/#/c/42385/
https://forge.typo3.org/issues/43085
https://github.com/TYPO3/TYPO3.CMS/commit/1f4b97454d05d7cb1be2a78b6a6e9f8fad736942#diff-2706384679a406d049dd75857e4c4ebeL105
Since then, config.processor_allowUpscaling is checked and it's reversed now.
Generally, it would make sense to switch to (e.g.) config.allowUpscaling, but we have to announce that as breakingchange-rst or by deprecating the old one config.noScaleUp AND of course, adding that information in the TYPO3 documentation!
My suggested solution¶
I would suggest to deprecate the old one and switch to a meaningful naming like config.allowUpscaling
Updated by Benni Mack over 7 years ago
Hey Josef,
I wonder if we should make the old property work again, but deprecate it, as I don't see a reason to have this configurable on a "per-TypoScript" condition / setting level. Either I do this per installation or I don't (well, I personally don't see the reason for this option at all, but globally it would be fine for me). What'ya think?
Updated by Daniel Goerz over 7 years ago
- Sprint Focus set to Stabilization Sprint
Updated by Riccardo De Contardi over 7 years ago
Is this one related, maybe? https://forge.typo3.org/issues/72554
Updated by
Updated by Josef Glatz over 7 years ago
Sounds like a great idea, Benni!
In most project I've seen these setting is defacto a default setting. I'm fine with just configure that via global configuration.
Updated by Josef Glatz over 7 years ago
- Status changed from New to Accepted
- Assignee set to Josef Glatz
Updated by Gerrit Code Review over 7 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50236
Updated by Gerrit Code Review over 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50236
Updated by Gerrit Code Review over 7 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50236
Updated by Gerrit Code Review over 7 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50236
Updated by Gerrit Code Review over 7 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50236
Updated by Gerrit Code Review over 7 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50236
Updated by Anonymous over 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 87d35e376f271cbc5f6e9a5349d73c337d6a029f.
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed