config.noScaleUp no longer works
config.noScaleUp no longer works since:
config.processor_allowUpscaling is checked and it's reversed now.
Generally, it would make sense to switch to (e.g.)
config.allowUpscaling, but we have to announce that as breakingchange-rst or by deprecating the old one
config.noScaleUp AND of course, adding that information in the TYPO3 documentation!
My suggested solution¶
I would suggest to deprecate the old one and switch to a meaningful naming like
[BUGFIX] Make TypoScript option config.noScaleUp work again
A former commit introduced a bug, which makes `config.noScaleUp`
useless. This commit fixes the regression introduced in
https://review.typo3.org/#/c/42385/ by making the option work again.
Reviewed-by: Benni Mack <email@example.com>
Tested-by: Benni Mack <firstname.lastname@example.org>
Tested-by: TYPO3com <email@example.com>
Reviewed-by: Wouter Wolters <firstname.lastname@example.org>
Tested-by: Wouter Wolters <email@example.com>
#2 Updated by Benni Mack almost 3 years ago
I wonder if we should make the old property work again, but deprecate it, as I don't see a reason to have this configurable on a "per-TypoScript" condition / setting level. Either I do this per installation or I don't (well, I personally don't see the reason for this option at all, but globally it would be fine for me). What'ya think?