Task #78702

Install Tool: System environment check should display a warning if PHP fileinfo extension is not loaded

Added by Florian Wessels over 2 years ago. Updated 8 months ago.

Status:
Closed
Priority:
Should have
Category:
Install Tool
Target version:
-
Start date:
2016-11-15
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
5.6
Tags:
Complexity:
easy
Sprint Focus:
On Location Sprint

Description

If the PHP extension "fileinfo" is not loaded, the system environment check in the install tool should throw an error because extracting of file metadata (e.g. mime-types) will fail (if the function 'mime_content_type' (deprecated) also not exists).


Related issues

Related to TYPO3 Core - Task #77153: Mention fileinfo PHP extension Closed 2016-07-19
Related to TYPO3 Core - Task #74177: Remove fileinfo as dependency in SystemEnvironment/Check Closed 2016-03-04

Associated revisions

Revision 4337087a (diff)
Added by Jonathan IROULIN over 1 year ago

[TASK] Install Tool: Display a warning if PHP fileinfo extension is not loaded

Show a warning message during the installation process if
the PHP fileinfo extension is not loaded.
It only displays a warning because the fileinfo extension is just
a suggestions and not required.
The fileinfo extension is useful to extract file metadata.

Resolves: #78702
Releases: master, 8.7
Change-Id: Iea0fa087d96d5615056308b7b2fef082b9154a2d
Reviewed-on: https://review.typo3.org/54823
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision 7eda1b6e (diff)
Added by Jonathan IROULIN over 1 year ago

[TASK] Install Tool: Display a warning if PHP fileinfo extension is not loaded

Show a warning message during the installation process if
the PHP fileinfo extension is not loaded.
It only displays a warning because the fileinfo extension is just
a suggestions and not required.
The fileinfo extension is useful to extract file metadata.

Resolves: #78702
Releases: master, 8.7
Change-Id: Iea0fa087d96d5615056308b7b2fef082b9154a2d
Reviewed-on: https://review.typo3.org/54833
Tested-by: TYPO3com <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50662

#2 Updated by Frans Saris over 2 years ago

  • Status changed from Under Review to Needs Feedback

See #74177 there is was removed as required extension. It should indeed be mentioned somewhere. But it isn't required correct?

#3 Updated by Alexander Opitz over 2 years ago

  • Status changed from Needs Feedback to Closed

No feedback within the last 90 days => closing this issue.

If you think that this is the wrong decision or experience this issue again, then please write to the mailing list typo3.teams.bugs with issue number and an explanation or open a new ticket and add a relation to this ticket number.

#4 Updated by Ralf Merz about 2 years ago

  • Priority changed from Should have to Must have

Hi guys,

I want you to bring back the finfo check back into install tool, because without that, the following happens:

We hav a customer hosting its website on their own, where they use a Suse Linux. I do no exactly know how PHP 7.0 has been installed, but the class finfo was not there.
This leads to the problem that ImageMagick does not know how big an image is (size in pixels) and it renders images to 0x0px. So in frontend you have a correct src to "_processed_/blabla", but in the image-tag itself, width and height will be rendered as
width=0 and height=0.

I found out that the size of the image wants to be fetched via "vendor/typo3/cms/typo3/sysext/core/Classes/Type/File/FileInfo.php". There is a check if the method exists. If not, the returned $mimeType is empty which causes confusing errors in the frontend.

So the install tool must check if this class is around, as it is possible that PHP does to have finfo included.

Thanks and greets
Ralf aka merzilla

#5 Updated by Frans Saris about 2 years ago

  • Status changed from Closed to Accepted
  • Priority changed from Must have to Should have

Is should be a system warning in the install tool

#6 Updated by Susanne Moog over 1 year ago

  • Sprint Focus set to On Location Sprint

#7 Updated by Jonathan IROULIN over 1 year ago

  • Assignee set to Jonathan IROULIN

#8 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54823

#9 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54823

#10 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54823

#11 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54823

#12 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54823

#13 Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54823

#14 Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54823

#15 Updated by Gerrit Code Review over 1 year ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54823

#16 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54833

#17 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54833

#18 Updated by Jonathan IROULIN over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#19 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50662

#20 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50662

#21 Updated by Markus Klein over 1 year ago

  • Status changed from Under Review to Resolved

#22 Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF