Bug #78976

Epic #83669: Improve file list / file browser

Add missing DOM ready check for JavaScripts in filelist module

Added by Gleb Levitin almost 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Backend JavaScript
Target version:
Start date:
2016-12-13
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

In spite of adding the missing DOM ready checks to various AMD modules in #70601, there is still a number of AMDs in the Core, suffering from this defect.
For example the JavaScripts from filelist Extension, placed in SYSEXT:filelist/Resources/Public/JavaScript are affected by this defect.


Related issues

Related to TYPO3 Core - Bug #70601: Add missing to DOM ready checks to all AMD modules Closed 2015-10-12
Related to TYPO3 Core - Task #78975: Refactor DOM ready check with AMD loader plugin domReady Closed 2016-12-13

Associated revisions

Revision 308242ea (diff)
Added by Frank Naegler almost 2 years ago

[BUGFIX] Add missing DOM ready checks in filelist

Some modules in the filelist are missing DOM ready checks.
This patch adds the missing checks to prevent loading issues.

Resolves: #78976
Releases: master, 8.7
Change-Id: Iee328808a89cf92f4fde1afd59167ae9fa7280be
Reviewed-on: https://review.typo3.org/55390
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>
Tested-by: TYPO3com <>
Reviewed-by: Mathias Brodala <>
Reviewed-by: Alexander Opitz <>
Tested-by: Alexander Opitz <>

Revision 86b439e4 (diff)
Added by Frank Naegler almost 2 years ago

[BUGFIX] Add missing DOM ready checks in filelist

Some modules in the filelist are missing DOM ready checks.
This patch adds the missing checks to prevent loading issues.

Resolves: #78976
Releases: master, 8.7
Change-Id: Iee328808a89cf92f4fde1afd59167ae9fa7280be
Reviewed-on: https://review.typo3.org/55564
Tested-by: TYPO3com <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Jigal van Hemert <>
Tested-by: Jigal van Hemert <>

History

#1 Updated by Frank Naegler about 2 years ago

  • Status changed from New to Accepted

good catch, this should be fixed, please answer on my question in the other issue, then we can try to fix both issues.

#2 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55390

#3 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55390

#4 Updated by Frank Naegler almost 2 years ago

  • Assignee set to Frank Naegler

#5 Updated by Riccardo De Contardi almost 2 years ago

  • Parent task set to #83669

#6 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55390

#7 Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55390

#8 Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55390

#9 Updated by Gerrit Code Review almost 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55390

#10 Updated by Gerrit Code Review almost 2 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55390

#11 Updated by Gerrit Code Review almost 2 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55390

#12 Updated by Gerrit Code Review almost 2 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55390

#13 Updated by Gerrit Code Review almost 2 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55390

#14 Updated by Gerrit Code Review almost 2 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55390

#15 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55564

#16 Updated by Frank Naegler almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#17 Updated by Alexander Opitz almost 2 years ago

  • Target version set to 8.7.10

#18 Updated by Christian Kuhn almost 2 years ago

  • Status changed from Resolved to Under Review

#19 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55564

#20 Updated by Frank Naegler almost 2 years ago

  • Status changed from Under Review to Resolved

#21 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF