Bug #80036
open
FAL translation with TCA maxitems set
Added by Kai Tallafus over 7 years ago.
Updated 10 months ago.
Sprint Focus:
Stabilization Sprint
Description
There is a bug with "Localize all records" and "Synchronize with original language".
In my TCA a have a FAL field with maxitems=1.
If I go to the translated record and hit one of those buttons, I get the error message "A maximum of 1 child records are allowed.".
However, after reloading the form, it seems the FAL record is translated.
Related issues
1 (1 open — 0 closed)
- Category changed from FormEngine aka TCEforms to Localization
- Status changed from New to Accepted
- Is Regression changed from No to Yes
- Sprint Focus set to Stabilization Sprint
I can confirm this bug. It also affects version 7.
This is a JS error message and luckily does not affect the ajax request to localize any child records.
Affected line of code: typo3/sysext/backend/Resources/Public/JavaScript/jsfunc.inline.js:155
The script fires an error notification if the number of childs is equal or greater than the defined 'maxitems' of the TCA (only 'below max' is valid).
Typo3 version is 8.7.10
- Status changed from Accepted to Under Review
Gerrit Code Review wrote:
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57124
Patch for TYPO3_7.6!
By removing the redundant isBelowMax condition in domAddNewRecord the localize or synchronize function will no longer throw a fake message for elements with the tca setting 'maxitems=1'. I removed the message output completely in domAddNewRecord, because the new button disappears if the 'maxitems' amount is reached. Also adding the 'isBelowMax' condition in synchronizeLocalizeRecords to prevent an fatal error by create a new element followed by the localize button.
- Related to Bug #82880: Synchronize inline records triggers maxItemsError added
- Status changed from Under Review to New
Its kind of wrong question. isBelowMax tests recordCount >= this.data.config[objectPrefix].max.
While configured in TCA maxItem are allowed.
So lets ask if isNotAboveMax e.g.
!(recordCount > this.data.config[objectPrefix].max)
Can still confirm this issue on TYPO3 9.5.20 with PHP 7.2
Could you please provide more information, such as:
- what language configuration for the site do you have
- attach the TCA for the problematic field
I tested it on T3-dev (13) by modifying the core image field and setting maxitems to 1 or 2, and enabling the showSynchronizationLink and showAllLocalizationLink options. In both cases, the translation worked fine for me (a page with 2 languages available). There were no JS errors displayed in the TYPO3 panel.
Sadly, I can't provide information about this issue anymore. Maybe one of the other contributors can.
Also available in: Atom
PDF