Bug #80969

List module: Content elments with additional column pi_flexform results in exception "Prohibited input U+0000000A"

Added by Alex Kellner over 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2017-04-23
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Source: https://github.com/einpraegsam/powermail/issues/63

If (e.g.) a powermail pluin is on a page in TYPO3 8.7 and the FlexForm is filled with some plugin settings (email addresses of the receiver, etc...). The list module can throw an exception, if the field pi_flexform should be displayed as additional column.

Exception message:

NAMEPREP: Prohibited input U+0000000A
in Mso\IdnaConvert\Punycode::namePrep()

How to reproduce step by step:
  • Add a FlexForm string to any content element in tt_content.pi_flexform (see below) or simply add a powermail plugin with some settings
  • Switch to list module
  • Click on the title of the table "Page Content"
  • Select Plugin Options to be shown in addition in the list view table and then submit
  • An exception is given

Example FlexForm:

<?xml version="1.0" encoding="utf-8" standalone="yes" ?> <T3FlexForms> <data> <sheet index="main"> <language index="lDEF"> <field index="settings.flexform.main.form"> <value index="vDEF">16</value> </field> <field index="settings.flexform.main.confirmation"> <value index="vDEF">0</value> </field> <field index="settings.flexform.main.optin"> <value index="vDEF">0</value> </field> <field index="settings.flexform.main.moresteps"> <value index="vDEF">0</value> </field> <field index="settings.flexform.main.pid"> <value index="vDEF"></value> </field> </language> </sheet> <sheet index="receiver"> <language index="lDEF"> <field index="settings.flexform.receiver.name"> <value index="vDEF">Company Name</value> </field> <field index="settings.flexform.receiver.email"> <value index="vDEF">contact@company.com</value> </field> <field index="settings.flexform.receiver.fe_group"> <value index="vDEF"></value> </field> <field index="settings.flexform.receiver.subject"> <value index="vDEF">Website Contact from {firstname} {lastname}</value> </field> <field index="settings.flexform.receiver.body"> <value index="vDEF">&lt;p&gt;{powermail_all}&lt;/p&gt;</value> </field> <field index="settings.flexform.receiver.type"> <value index="vDEF">0</value> </field> </language> </sheet> <sheet index="sender"> <language index="lDEF"> <field index="settings.flexform.sender.name"> <value index="vDEF">Company Name</value> </field> <field index="settings.flexform.sender.email"> <value index="vDEF">contact@company.com</value> </field> <field index="settings.flexform.sender.subject"> <value index="vDEF">Thank you for contacting us</value> </field> <field index="settings.flexform.sender.body"> <value index="vDEF">&lt;p&gt;{powermail_all}&lt;/p&gt;</value> </field> </language> </sheet> <sheet index="thx"> <language index="lDEF"> <field index="settings.flexform.thx.body"> <value index="vDEF">Thank you for contacting us</value> </field> <field index="settings.flexform.thx.redirect"> <value index="vDEF"></value> </field> </language> </sheet> </data> </T3FlexForms>


Related issues

Related to TYPO3 Core - Bug #81471: Catch InvalidArgumentException thrown in \TYPO3\CMS\Core\Utility\GeneralUtility::idnaEncodeClosedNicole Cordes2017-06-05

Actions
Has duplicate TYPO3 Core - Bug #81211: Uncought Exeption in list-modul (NAMEPREP: Prohibited input U+0000003E)Rejected2017-05-12

Actions
#1

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52559

#2

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52559

#3

Updated by Wouter Wolters over 3 years ago

  • Has duplicate Bug #81211: Uncought Exeption in list-modul (NAMEPREP: Prohibited input U+0000003E) added
#4

Updated by Wolfgang Klinger over 3 years ago

  • Priority changed from Should have to Must have

The same exception is thrown in GeneralUtility::isValidUrl

0: InvalidArgumentException: NAMEPREP: Prohibited input U+0000007B in /var/www/something/htdocs/vendor/mso/idna-convert/src/Punycode.php:335 
Stack trace: 
#0 /var/www/something/htdocs/vendor/mso/idna-convert/src/Punycode.php(187): Mso\IdnaConvert\Punycode->namePrep(Array) 
#1 /var/www/something/htdocs/vendor/mso/idna-convert/src/IdnaConvert.php(327): Mso\IdnaConvert\Punycode->encode(Array) 
#2 /var/www/something/htdocs/vendor/typo3/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php(1089): Mso\IdnaConvert\IdnaConvert->encode(Array) 
#3 /var/www/something/htdocs/vendor/typo3/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php(1201): TYPO3\CMS\Core\Utility\GeneralUtility::idnaEncode('{$unresolved_constant...') 
#4 /var/www/something/htdocs/web/typo3conf/ext/solr/Classes/ViewHelper/Link.php(101): TYPO3\CMS\Core\Utility\GeneralUtility::isValidUrl('http://{$plugin...') 
#5 /var/www/something/htdocs/web/typo3conf/ext/solr/Classes/Template.php

so the patch is incomplete

#5

Updated by Wolfgang Klinger over 3 years ago

  • Related to Bug #81471: Catch InvalidArgumentException thrown in \TYPO3\CMS\Core\Utility\GeneralUtility::idnaEncode added
#6

Updated by Georg Ringer over 3 years ago

  • Status changed from Under Review to Resolved

should be reolsved with #81471

#7

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF