Bug #81164

Indexed Search appends ?L=0 to URLs of search results

Added by Ben Robinson over 4 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Indexed Search
Start date:
2017-05-07
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:
On Location Sprint

Description

The link-urls on the result page of indexed search are appended by "?L=0" (monolingual site).

I found a fix on https://forum.typo3.org/index.php/t/214259/ :

In TYPO3 8.7.1 change line 1314 of /sysext/indexed_search/Classes/Controller/SearchController.php from ...

        $urlParameters['L'] = $row['sys_language_uid'];
...to:
        if ($row['sys_language_uid']) {
        $urlParameters['L'] = $row['sys_language_uid'];
        }


Related issues

Related to TYPO3 Core - Bug #30852: Multilingual search in translated pages: Results of default language always linking to current language Closed2011-10-12

Actions
Related to TYPO3 Core - Bug #81986: indexed_search generates duplicated results for same pageNew2017-07-27

Actions
#1

Updated by Wouter Wolters over 4 years ago

Hi, would be great if you could push a patch to our review system.
You can find a guideline at https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/
If you have any question please don't hesitate to contact us on Slack in the #typo3-cms-coredev channel.

#2

Updated by Ben Robinson over 4 years ago

To be honest, I'm not a PHP-developer. I just found this bugfix, tried it and it seems to work, but I have no clue about the variable $row or if this is a clean solution for the issue. If you nevertheless want me to push it, I can try to get familiar with the contributing workflow, but it may take some time. What do you think?

#3

Updated by Mona Muzaffar about 4 years ago

  • Related to Bug #30852: Multilingual search in translated pages: Results of default language always linking to current language added
#4

Updated by Mona Muzaffar about 4 years ago

  • Related to Bug #81986: indexed_search generates duplicated results for same page added
#5

Updated by Gerrit Code Review about 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53978

#6

Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53978

#7

Updated by Łukasz Uznański about 4 years ago

  • Sprint Focus set to On Location Sprint
#8

Updated by Gerrit Code Review about 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53978

#9

Updated by Gerrit Code Review about 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53978

#10

Updated by Gerrit Code Review almost 4 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54178

#11

Updated by Łukasz Uznański almost 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#12

Updated by Benni Mack almost 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF