Bug #82178

\TYPO3\CMS\Backend\Form\Container\InlineRecordContainer::renderForeignRecordHeaderControl wrong edit link

Added by Marcos Fadul about 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2017-08-23
Due date:
% Done:

0%

TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
Sprint Focus:
On Location Sprint

Description

The $recordInDatabase in line 506 is false if no metadata for the file exist. This produce a wrong edit link where uid is null. This can be fix by adding a check on $recordInDatabase in the if condition on line 522.
if ($recordInDatabase && $backendUser->check('tables_modify', 'sys_file_metadata')) {


Related issues

Duplicates TYPO3 Core - Bug #76262: "$uid must be positive integer, 0 given" when trying to edit file metadata Closed 2016-05-23
Duplicated by TYPO3 Core - Bug #83165: Editing file metadata of translated tt_content Closed 2017-11-29

Associated revisions

Revision bf6ee546 (diff)
Added by Łukasz Uznański almost 2 years ago

[BUGFIX] Disable edit of file metadata without translation

This avoids an error in case file metadata is edited through a file
reference and there is no file metadata translation for the current
language.

Resolves: #76262
Resolves: #82178
Releases: master, 8.7
Change-Id: Ifecf659637773c5f3773fc3439b09df9c030cb3f
Reviewed-on: https://review.typo3.org/54778
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision 15f06616 (diff)
Added by Łukasz Uznański almost 2 years ago

[BUGFIX] Disable edit of file metadata without translation

This avoids an error in case file metadata is edited through a file
reference and there is no file metadata translation for the current
language.

Resolves: #76262
Resolves: #82178
Releases: master, 8.7
Change-Id: Ifecf659637773c5f3773fc3439b09df9c030cb3f
Reviewed-on: https://review.typo3.org/54822
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision 0bc3e6c1 (diff)
Added by Łukasz Uznański over 1 year ago

[BUGFIX] Disable edit of file metadata without translation

This avoids an error in case file metadata is edited through a file
reference and there is no file metadata translation for the current
language.

Resolves: #76262
Resolves: #82178
Releases: master, 8.7, 7.6
Change-Id: Ifecf659637773c5f3773fc3439b09df9c030cb3f
Reviewed-on: https://review.typo3.org/56568
Tested-by: TYPO3com <>
Reviewed-by: Alexander Stehlik <>
Tested-by: Alexander Stehlik <>
Reviewed-by: Stephan Großberndt <>
Reviewed-by: Rudy Gnodde <>
Reviewed-by: Mathias Brodala <>
Tested-by: Mathias Brodala <>

History

#1 Updated by Łukasz Uznański almost 2 years ago

  • Sprint Focus set to On Location Sprint

#2 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54778

#3 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54778

#4 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54778

#5 Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54778

#6 Updated by Mathias Brodala almost 2 years ago

  • Duplicates Bug #76262: "$uid must be positive integer, 0 given" when trying to edit file metadata added

#7 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54822

#8 Updated by Łukasz Uznański almost 2 years ago

  • Status changed from Under Review to Resolved

#9 Updated by Mathias Schreiber almost 2 years ago

  • Duplicated by Bug #83165: Editing file metadata of translated tt_content added

#10 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56568

#11 Updated by Łukasz Uznański over 1 year ago

  • Status changed from Under Review to Resolved

#12 Updated by Sebastian Michaelsen about 1 year ago

  • Status changed from Resolved to New

When a record is in a certain language (sys_language_uid > 0) it does not mean the meta data of a referenced file have to be translated into the same language.
When you work with separate files in different languages (e.g. PDFs) you will usually not have translated meta data records, you still should be able to access/edit them.

My proposal is to link to the according meta data translation if possible (as it is now) and link to the meta data in the default language if there is no matching translation.

#13 Updated by Anja Leichsenring about 1 year ago

  • Status changed from New to Resolved

@Sebastian, can you please open a new ticket to your issue? The issue described in the ticket has been resolved by the patches merged. You are welcome to set a relation to this one on the new ticket so we can easily follow up on the different stages the behavior went trough.

If you need a different behavior, please describe it in a little more detail than you did here, and do in a separate ticket. It's easier to keep track of the changes then.

Thanks a bunch.

I close this ticket again for the named reason.

#14 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF