Bug #82456

Multiple usage of "save and preview" button does not reload preview tab

Added by Felix Nagel 2 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2017-09-11
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

When editing a content element, it's possible that an editor clicks the "save and preview" button after each content change. In this case, the preview tab will not reload and therefor will not show updated content.

Steps to reproduce:

  • Add a text content element
  • Use "save and preview" button -> new tab opens
  • Go back to BE tab and change content
  • Click "save and preview" button again -> preview tabs gets focus but does not reload

Introduced with TYPO3 8.7.5 in this commit: https://github.com/TYPO3/TYPO3.CMS/commit/4973abb62beed43e37f6377e10ef1d48ba8c1c8f

Using a simple `previewWin.location.reload();` in `viewOnClick` solves the issue but breaks the initial click on "save and preview". Perhaps adding a time stamp GET parameter is another option? Or adding some on load event?


Related issues

Related to TYPO3 Core - Bug #81250: Preview link of content element misses the anchor in some cases Under Review 2017-05-18

Associated revisions

Revision 25ff9e94 (diff)
Added by Frank Naegler about 2 months ago

Revert "[BUGFIX] Set anchor in all preview links of content elements"

Because of a regression, the patch will be reverted for the v8 branch, for master we will merge a bugfix.

This reverts commit 6a480e998cd8113780504c5d7cfb99f948c3238c.

Change-Id: If467b5c90e34307fc0baa10fc140ea9f19c30e30
Releases: 8.7
Resolves: #82456
Reverts: #81250
Reviewed-on: https://review.typo3.org/54228
Reviewed-by: Andreas Fernandez <>
Tested-by: TYPO3com <>
Reviewed-by: Helmut Hummel <>
Tested-by: Helmut Hummel <>
Tested-by: Jasmina Ließmann Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

Revision 78f0bf0e (diff)
Added by Frank Naegler about 2 months ago

[BUGFIX] Fix broken reload of save+preview links

Resolves: #82456
Related: #81250
Releases: master
Change-Id: Idab208c3273adbd5800edab51bd9ca7bbec19af8
Reviewed-on: https://review.typo3.org/54218
Tested-by: TYPO3com <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Jasmina Ließmann Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com> Reviewed-by: Helmut Hummel <typo3@helhum.io> Tested-by: Helmut Hummel <typo3@helhum.io>

History

#1 Updated by Felix Nagel 2 months ago

  • Related to Bug #81250: Preview link of content element misses the anchor in some cases added

#2 Updated by Helmut Hummel about 2 months ago

  • Status changed from New to Accepted

I can confirm this

#3 Updated by Helmut Hummel about 2 months ago

  • Is Regression set to Yes

#4 Updated by Frank Naegler about 2 months ago

  • Status changed from Accepted to In Progress
  • Assignee set to Frank Naegler

#5 Updated by Gerrit Code Review about 2 months ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54218

#6 Updated by Gerrit Code Review about 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54218

#7 Updated by Gerrit Code Review about 2 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54218

#8 Updated by Gerrit Code Review about 2 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54218

#9 Updated by Gerrit Code Review about 2 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54218

#10 Updated by Gerrit Code Review about 2 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54218

#11 Updated by Gerrit Code Review about 2 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54218

#12 Updated by Gerrit Code Review about 2 months ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54228

#13 Updated by Gerrit Code Review about 2 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54218

#14 Updated by Frank Naegler about 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF