TYPO3 Core

see #81341 for the original issue. as this is deep into doctrine DBAL (https://github.com/doctrine/dbal/pull/2825) and those fix it only upstream I don't see any way to make it work in TYPO3. therefore I would propose to close this issue.

The fixes in doctrine/dbal (master) will be released with dbal 2.7.0 then. But since 2.6.0 they have a minimum php-requirement for 7.1, so that's not an option for us on TYPO3 8 LTS. I expect we'll have that for TYPO3 9 maybe (#83478).

So I see this forge-issue as a call for solution for 8 LTS only. Raising the dbal-version is not an option. Either we'd need to backport a patch ourselves and ship a patched dbal (potentially patching "cleanly" via composer?), find a different solution or finally decide we won't have MariaDB 10.2-support for 8 LTS.

I really would like to avoid patching 3rd party code because what happens if there are security issues in doctrine/dbal ... we would need to take care about those as well then.

Regarding PHP 7.1. As PHP 7.0 is EOL Dec2018, I see the best solution to ask users to install TYPO3 with composer and PHP 7.1 and everything is fine and we don't need anything from our side.

i fixed that locally for v7 very easy, as we have this old DB class, so inside INSERTquery i added following:

      // Build query
        $keys = array_keys($fields_values);
        foreach ($keys as $id => $key) {
            $keys[$id] = '`' . $key . '`';
        }
        $query = 'INSERT INTO ' . $table . ' (' . implode(',', array_values($keys)) . ') VALUES ' . '(' . implode(',', $fields_values) . ')';

Steffen Kamper wrote:

i fixed that locally for v7 very easy, as we have this old DB class, so inside INSERTquery i added following:

[...]

Hi Steffen - where exactly would I add / change that in v7?

Rico Leuthold wrote:

Steffen Kamper wrote:

i fixed that locally for v7 very easy, as we have this old DB class, so inside INSERTquery i added following:

[...]

Hi Steffen - where exactly would I add / change that in v7?

Hi Rico - search for:

// Build query

$query = 'INSERT INTO ' . $table . ' (' . implode(',', array_keys($fields_values)) . ') VALUES ' . '(' . implode(',', $fields_values) . ')';

in: typo3/sysext/core/Classes/Database/DatabaseConnection.php

and replace it like this:

           // Build query

                   $keys = array_keys($fields_values);
                foreach ($keys as $id => $key) {
                    $keys[$id] = '`' . $key . '`';
                   }
                   $query = 'INSERT INTO ' . $table . ' (' . implode(',', array_values($keys)) . ') VALUES ' . '(' . implode(',', $fields_values) . ')';