Task #83603

sysext/indexed_search using deprecated tx_crawler_lib class

Added by Tomas Norre Mikkelsen over 1 year ago. Updated 3 days ago.

Status:
Under Review
Priority:
Should have
Category:
Indexed Search
Target version:
-
Start date:
2018-01-17
Due date:
% Done:

0%

Estimated time:
1.00 h
TYPO3 Version:
10
PHP Version:
7.2
Tags:
Complexity:
hard
Sprint Focus:

Description

The class "\tx_crawler_lib::class" doesn't exist within the crawler since version 6.0.0, but the sysext/indexed_search are still using it. https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/indexed_search/Classes/Indexer.php#l757

This is now namespaced and removed:
\AOE\Crawler\Controller\CrawlerController::class

This makes it break if not using composer, not all switched to composer yet. In composer it's working due to the ClassMapAlias. https://github.com/AOEpeople/crawler/issues/262

We are planning on implementing a work-around for now, with e.g. class_alias().

I would like to fix this for:
TYPO3 7.6, 8.9, 9.x and dev-master of course.

https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/indexed_search/Classes/Indexer.php#l757

I would like to fix this, I have assigned myself to the task, let me know if that's not ok.

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55387

#2 Updated by Tomas Norre Mikkelsen over 1 year ago

I mean TYPO3 8.7 of course instead of 8.9 :) Ups

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55387

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55387

#5 Updated by Tymoteusz Motylewski over 1 year ago

  • Status changed from Under Review to New

This issue should be solved by introducing a new hook. This way we wouldn't need to hardcode a 3rd party class.

#6 Updated by Tizian Schmidlin 15 days ago

As discussed between Benni Mack, Tomas Norre Mikkelsen and Tizian Schmidlin, we'd solve this issue with a kind of "worker" class.

The idea is to replace the cross reference inside of the Indexer::extractLinks method by a call to a IndexWorkerFactory that would return the correct object.

So instead of having a check to know if we want to know if we want to use crawler and check if the crawler is loaded, we just instantiate a Worker-object through the Factory and then just use this.

I'll try to tackle this during the T3DD19 and the next weeks.

#7 Updated by Gerrit Code Review 14 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431

#8 Updated by Gerrit Code Review 13 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431

#9 Updated by Gerrit Code Review 12 days ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431

#10 Updated by Gerrit Code Review 12 days ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431

#11 Updated by Gerrit Code Review 12 days ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431

#12 Updated by Gerrit Code Review 12 days ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431

#13 Updated by Gerrit Code Review 12 days ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61444

#14 Updated by Gerrit Code Review 12 days ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431

#15 Updated by Gerrit Code Review 12 days ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431

#16 Updated by Gerrit Code Review 12 days ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431

#17 Updated by Gerrit Code Review 12 days ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431

#18 Updated by Gerrit Code Review 12 days ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431

#19 Updated by Tizian Schmidlin 12 days ago

  • TYPO3 Version changed from 7 to 10
  • PHP Version changed from 5.5 to 7.2
  • Complexity changed from no-brainer to hard

#20 Updated by Gerrit Code Review 11 days ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431

#21 Updated by Gerrit Code Review 3 days ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431

#22 Updated by Gerrit Code Review 3 days ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431

Also available in: Atom PDF