Task #83603
closed
sysext/indexed_search using deprecated tx_crawler_lib class
Added by Tomas Norre Mikkelsen over 6 years ago. Updated over 2 years ago.
0%
Description
The class "\tx_crawler_lib::class" doesn't exist within the crawler since version 6.0.0, but the sysext/indexed_search are still using it. https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/indexed_search/Classes/Indexer.php#l757
This is now namespaced and removed:
\AOE\Crawler\Controller\CrawlerController::class
This makes it break if not using composer, not all switched to composer yet. In composer it's working due to the ClassMapAlias. https://github.com/AOEpeople/crawler/issues/262
We are planning on implementing a work-around for now, with e.g. class_alias().
I would like to fix this for:
TYPO3 7.6, 8.9, 9.x and dev-master of course.
I would like to fix this, I have assigned myself to the task, let me know if that's not ok.
Updated by Gerrit Code Review over 6 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55387
Updated by Tomas Norre Mikkelsen over 6 years ago
I mean TYPO3 8.7 of course instead of 8.9 :) Ups
Updated by Gerrit Code Review over 6 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55387
Updated by Gerrit Code Review over 6 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55387
Updated by Tymoteusz Motylewski over 6 years ago
- Status changed from Under Review to New
This issue should be solved by introducing a new hook. This way we wouldn't need to hardcode a 3rd party class.
Updated by Tizian Schmidlin almost 5 years ago
As discussed between Benni Mack, Tomas Norre Mikkelsen and Tizian Schmidlin, we'd solve this issue with a kind of "worker" class.
The idea is to replace the cross reference inside of the Indexer::extractLinks method by a call to a IndexWorkerFactory that would return the correct object.
So instead of having a check to know if we want to know if we want to use crawler and check if the crawler is loaded, we just instantiate a Worker-object through the Factory and then just use this.
I'll try to tackle this during the T3DD19 and the next weeks.
Updated by Gerrit Code Review over 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review over 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review over 4 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review over 4 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review over 4 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review over 4 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review over 4 years ago
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61444
Updated by Gerrit Code Review over 4 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review over 4 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review over 4 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review over 4 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review over 4 years ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Tizian Schmidlin over 4 years ago
- TYPO3 Version changed from 7 to 10
- PHP Version changed from 5.5 to 7.2
- Complexity changed from no-brainer to hard
Updated by Gerrit Code Review over 4 years ago
Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review over 4 years ago
Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review over 4 years ago
Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review over 4 years ago
Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review over 4 years ago
Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review over 4 years ago
Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Alexander Schnitzler about 4 years ago
- Related to Task #90384: Do not use ::class syntax for class tx_crawler_lib added
Updated by Gerrit Code Review about 4 years ago
Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review almost 4 years ago
Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review almost 4 years ago
Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review almost 4 years ago
Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review almost 4 years ago
Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review almost 4 years ago
Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review almost 4 years ago
Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61431
Updated by Gerrit Code Review almost 4 years ago
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64790
Updated by Gerrit Code Review almost 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64790
Updated by Gerrit Code Review almost 4 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64790
Updated by Gerrit Code Review almost 4 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64790
Updated by Gerrit Code Review almost 4 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64790
Updated by Christian Kuhn over 2 years ago
- Status changed from Under Review to Rejected
Updated by Tomas Norre Mikkelsen over 2 years ago
Thanks for doing housekeeping, Christian.
This work is "done" by not verified yet. Benni wanted to verify it, but as well all know, Benni has a lot on his plate. So no blame here.
Perhaps you could verify this? so we can have it merged.
The work needed for the Crawler is already done/prepared, so I would be nice if this could get into the 12 version, we hoped for the v11, but didn't happen.
Please reconsider re-opening this ticket.
Thanks