Bug #84146: "Reports" says update wizard incomplete - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #84146

closed

"Reports" says update wizard incomplete

Added by Gone With the Wind over 6 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Reports

Target version:

8.7.11

Start date:

2018-03-05

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

7.1

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

The Reports tool says that the update wizard is incomplete and recommends to switch to the install tool and check the update wizard there.
But the install tool's update wizard shows 100%.

This happened after an update from 8.7.9 to 8.7.10, php 7.1.13 on at least 3 different installations.

Images included.

Files

Download all files

Screen Shot 2018-03-05 at 22.30.05.png (69.7 KB) Screen Shot 2018-03-05 at 22.30.05.png		Gone With the Wind, 2018-03-05 22:31
Screen Shot 2018-03-05 at 22.32.01.png (34.6 KB) Screen Shot 2018-03-05 at 22.32.01.png		Gone With the Wind, 2018-03-05 22:32

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Georg Ringer over 6 years ago

Status changed from New to Accepted
Target version changed from 9.2 to 8.7.11

Actions

Copy link

Updated by Jigal van Hemert over 6 years ago

Status changed from Accepted to Needs Feedback

Robert, it seems that at least one of the upgrade wizards in the context of the Reports modules finds that it hasn't finished the upgrade.
Can you modify \TYPO3\CMS\Install\Report\InstallStatusReport::getRemainingUpdatesStatus() to make $message show $identifier and $className?

It could be that more wizards think they are not finished. In that case the code could be:

if ($updateObject->shouldRenderWizard()) {
  // at least one wizard was found
  $value = $languageService->getLL('status_updateIncomplete');
  $severity = Status::WARNING;
  $url = BackendUtility::getModuleUrl('system_extinstall');
  $message .= $identifier . ':' . $className . ', ';
}

From there the affected wizards can be checked further.

Actions

Copy link

Updated by Gone With the Wind over 6 years ago

Jigal - do your TYPO3 installations n ot show the same problem?

Message after implementing your script:

Update Incomplete
This installation is not configured for the TYPO3 version it is running. If you did so intentionally, this message can be safely ignored. If you are unsure, visit the Update Wizard section of the Install Tool to see how TYPO3 would change.
TYPO3\CMS\Install\Updates\DatabaseRowsUpdateWizard:TYPO3\CMS\Install\Updates\DatabaseRowsUpdateWizard,

Actions

Copy link

Updated by Jigal van Hemert over 6 years ago

Robert,

Finally I found an installation that shows this behaviour. It was in a different wizard. A patch will follow soon.

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Status changed from Needs Feedback to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56044

Actions

Copy link

Updated by Gone With the Wind over 6 years ago

Thanks a lot, Jigal, for your quick fix!
Looking into it...

Actions

Copy link

Updated by Gone With the Wind over 6 years ago

Thanks a lot, Jigal, for your quick fix!
The changed code works fine on my 8.7.10 installation. But the file itself (that is: your file) is a bit different in the import statement section (your file has less import statements than 8.7.10). Do I still vote +1?

A side note: There is a grammar error around line 62:
// 1 = required, don't has to be writable
should be:
// 1 = required, doesn't have to be writable

Can you take this fix along with this one or should I create a separate issue?

Actions

Copy link

Updated by Christian Kuhn over 6 years ago

Robert. Thanks for your testing! I may agree this fixes an issue for v8, but we're currently first discussing the patch for core master branch (v9). If that is sorted out, we later back port to v8. This is the reason the patch did not apply cleanly to v8 - a master variant has been pushed first. For master however, my testing says the v9 master core branch is not affected by the bug (maybe has been fixed meanwhile). If that turns out to be true and we can still reproduce the issue for v8, we may then decide to abandon the master patch and only fix it in v8 in a separate patch.

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56049

Actions

Copy link

#10