Bug #84267

Unique evaluation does not work with l10n_mode=exclude

Added by Christoph Lehmann about 1 year ago. Updated 16 days ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Localization
Target version:
-
Start date:
2018-03-14
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Translation handling changed with l10n_mode=exclude, the field is copied from default language to language children. In combination with eval=unique the language children get a unique value too like “fieldvalue1”.

My expected behaviour is: uniqueness is ignored for translated records, since the values are just copied.


Related issues

Related to TYPO3 Core - Task #86780: Add test for (wrong) unique eval handling in pages:alias Closed 2018-10-28
Duplicates TYPO3 Core - Bug #83572: Changed behaviour for uniqueInPid/unique in translated records Closed 2018-01-15
Duplicated by TYPO3 Core - Bug #84666: Page alias is changed for translated pages Closed 2018-04-08

Associated revisions

Revision 09b94a99 (diff)
Added by Andreas Wolf 7 months ago

[TASK] Add test for (wrong) unique eval handling in pages:alias

Change-Id: Ie47dbc9153d8a4dcbde15a7eb61c207bbcc34480
Resolves: #86780
Related: #84267
Related: #83572
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/57322
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision dd6713fe (diff)
Added by Christoph Lehmann 7 months ago

[BUGFIX] Ignore unique evaluation in l10n_mode exclude

The l10n_mode "exclude" explains to copy the field value from
source language, so unique evaluation should be ignored for
translated records.

Resolves: #84267
Resolves: #83572
Releases: master, 8.7
Change-Id: I6a086cb1fc447dda2cbcfe27f33ba9f3dd714f53
Reviewed-on: https://review.typo3.org/56151
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Christoph Lehmann about 1 year ago

I'm going to make a commit based on our quickfix

#2 Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56151

#3 Updated by Christoph Lehmann about 1 year ago

  • Assignee set to Oliver Hader

Example

An Attributegroup record is a collection of attributes, references them by a code (a comma-separated list) and is not translatable.
An attribute record is translatable and the code field has l10n_mode=exclude and eval=unique.

In Extbase the $wantedAttribute is not found in a foreign language since extbase only finds the attribute with code "fieldvalue1".

foreach ($attributeGroup->getCodes() as $attributeCode) {
    $wantedAttribute = $attributeRepository->findByCode($attributeCode); 
}

#4 Updated by Andreas Wolf about 1 year ago

  • Duplicates Bug #83572: Changed behaviour for uniqueInPid/unique in translated records added

#5 Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56151

#6 Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56151

#7 Updated by Gerrit Code Review about 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56151

#8 Updated by Gerrit Code Review about 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56151

#9 Updated by Susanne Moog about 1 year ago

  • Duplicated by Bug #84666: Page alias is changed for translated pages added

#10 Updated by Gerrit Code Review about 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56151

#11 Updated by Gerrit Code Review about 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56151

#12 Updated by Benni Mack 7 months ago

  • Related to Task #86780: Add test for (wrong) unique eval handling in pages:alias added

#13 Updated by Gerrit Code Review 7 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56151

#14 Updated by Christoph Lehmann 7 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#15 Updated by Benni Mack 16 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF