Bug #86186

No pseudo-site found in root line for workspaces

Added by Joerg Kummer 10 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
Start date:
2018-09-07
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When editing a new created page in workspace, editing is not possible - throws error No pseudo-site found in root line of page [n]

Reproduce:
- enable workspaces and create one for draft
- switch to draft workspace
- create new page in rootline, outside of any existing page tree or site configuration
- edit this newly created page (context menu in pagetree or any other edit button in list view)

Expect:
- Frame with form for page properties will open to start editing

Result:
- Error No pseudo-site found in root line of page returned

issueWsDraftPageEdit.png View (187 KB) Joerg Kummer, 2018-09-07 14:51


Related issues

Related to TYPO3 Core - Bug #85985: Error: No pseudo-site found in root line of page 3 Closed 2018-08-27
Related to TYPO3 Core - Bug #86678: Exception when using workspaces and using a site configuration Closed 2018-10-17
Related to TYPO3 Core - Bug #88586: No pseudo-site found in root line for workspaces New 2019-06-18

Associated revisions

Revision b3c17046 (diff)
Added by Benni Mack 5 months ago

[BUGFIX] Fix various "No pseudo-site found in root line of page" errors

Fixes workspace resolving etc.

The !empty statement is wrong as a string value "0" would not expect the
right return. This fixes the detection of l10n_parent.
Also check for sys_language_uid, too, to get the pid of the record
instead of its parent.

This also fixes opening categories (sys_category) when using EXT:news,
which calls this condition in TCA:
'displayCond' => 'USER:' . \TYPO3\CMS\Core\Compatibility\
PseudoSiteTcaDisplayCondition::class . '->isInPseudoSite:pages:false',

Check array index exists in SiteResolving.

Resolves: #79606
Resolves: #86186
Resolves: #86622
Resolves: #86678
Resolves: #86684
Releases: master, 9.5
Change-Id: If3ddf5eead2dddd51db3bcf751d71d3bc362ef35
Reviewed-on: https://review.typo3.org/59229
Tested-by: TYPO3com <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

Revision aa08d433 (diff)
Added by Benni Mack 5 months ago

[BUGFIX] Fix various "No pseudo-site found in root line of page" errors

Fixes workspace resolving etc.

The !empty statement is wrong as a string value "0" would not expect the
right return. This fixes the detection of l10n_parent.
Also check for sys_language_uid, too, to get the pid of the record
instead of its parent.

This also fixes opening categories (sys_category) when using EXT:news,
which calls this condition in TCA:
'displayCond' => 'USER:' . \TYPO3\CMS\Core\Compatibility\
PseudoSiteTcaDisplayCondition::class . '->isInPseudoSite:pages:false',

Check array index exists in SiteResolving.

Resolves: #79606
Resolves: #86186
Resolves: #86622
Resolves: #86678
Resolves: #86684
Releases: master, 9.5
Change-Id: If3ddf5eead2dddd51db3bcf751d71d3bc362ef35
Reviewed-on: https://review.typo3.org/59453
Tested-by: TYPO3com <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Joerg Kummer 10 months ago

  • Related to Bug #85985: Error: No pseudo-site found in root line of page 3 added

#2 Updated by Susanne Moog 10 months ago

  • Target version set to 9 LTS

#3 Updated by Susanne Moog 10 months ago

  • Status changed from New to Accepted

Background:

PseudoSiteFinder queries in \TYPO3\CMS\Core\Site\PseudoSiteFinder::getAllRootPagesWithoutSiteConfiguration for all pages with is_siteroot and pid 0 - pid 0 in this case filters the first draft version of the record in workspace (as that has pid -1) and the used FrontendWorkspaceRestriction then filters the NEW PLACEHOLDER (which has pid 0). Maybe this can be fixed by including the placeholders, but I'm unsure of possible side effects.

#4 Updated by Susanne Moog 9 months ago

  • Category set to Link Handling, Site Handling & Routing

#5 Updated by Benni Mack 9 months ago

  • Target version changed from 9 LTS to next-patchlevel

#6 Updated by Gerrit Code Review 7 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58898

#7 Updated by Gerrit Code Review 7 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58898

#8 Updated by Steffen Dietrich 7 months ago

I tried to come up with a solution and it's working so far....but I m not sure if it's the best way for solving this problem.
https://review.typo3.org/#/c/58898/

#9 Updated by Riccardo De Contardi 7 months ago

  • Related to Bug #86678: Exception when using workspaces and using a site configuration added

#10 Updated by Gerrit Code Review 6 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58898

#11 Updated by Gerrit Code Review 6 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59229

#12 Updated by Gerrit Code Review 5 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59453

#13 Updated by Benni Mack 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#14 Updated by Benni Mack about 2 months ago

  • Status changed from Resolved to Closed

#15 Updated by Philipp Seiler 8 days ago

  • Related to Bug #88586: No pseudo-site found in root line for workspaces added

Also available in: Atom PDF