Project

General

Profile

Actions

Bug #86611

closed

TYPO3 does not ask, if changed but unsaved "Shortcut Target" should be saved

Added by Helmut Winkelbach over 5 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend JavaScript
Target version:
-
Start date:
2018-10-09
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

After changing the shortcut target and hitting close without saving, TYPO3 does not ask, if changes should be saved.


Files

Bug #86611.jpg (80.9 KB) Bug #86611.jpg Helmut Winkelbach, 2018-10-11 22:40

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #88719: Close should recognize non-saved record - but failsClosed2019-07-11

Actions
Related to TYPO3 Core - Bug #88875: Modal Page altered not shown everytimeClosed2019-08-01

Actions
Actions #1

Updated by Helmut Winkelbach over 5 years ago

  • Subject changed from Page, "Shortcut Target", after changes and "close" the page closes, "doesn't ask for saving" to 9.5, Page, "Shortcut Target", after changes and "close" the page closes, "doesn't ask for saving"
Actions #2

Updated by Chris topher over 5 years ago

  • Project changed from 9 to TYPO3 Core
  • Subject changed from 9.5, Page, "Shortcut Target", after changes and "close" the page closes, "doesn't ask for saving" to TYPO3 does not ask, if changed but unsaved "Shortcut Target" should be saved
  • Description updated (diff)
  • TYPO3 Version set to 9
Actions #3

Updated by Georg Ringer over 5 years ago

  • Status changed from New to Needs Feedback

I can actually not conform that. using chrome, master TYPO3.

What I do:

  1. Having a page with doktype shortcut
  2. Opening the page
  3. Scroll to the field shortcut target
  4. use the suggest wizard, search for something, select it
  5. the border of the field gets blue (which means it has been edited
  6. hitting close
  7. being asked to save

do you do it differently?

Actions #4

Updated by Helmut Winkelbach over 5 years ago

Georg Ringer wrote:

I can actually not conform that. using chrome, master TYPO3.

What I do:

  1. Having a page with doktype shortcut
  2. Opening the page
  3. Scroll to the field shortcut target
  4. use the suggest wizard, search for something, select it
  5. the border of the field gets blue (which means it has been edited
  6. hitting close
  7. being asked to save

do you do it differently?

Hi Georg,i do it the same way as you, many times with FF and Chrome, Chrome also with deactivated extensions. With master TYPO3 from 2 days ago.
After changing the shortcut target and hitting close without saving, TYPO3 does not ask, if changes should be saved.

Actions #5

Updated by Riccardo De Contardi over 5 years ago

I did the same test as Georg, with the same results :S

do you have javascript errors?

Actions #6

Updated by Helmut Winkelbach over 5 years ago

Riccardo De Contardi wrote:

I did the same test as Georg, with the same results :S

do you have javascript errors?

Dear Riccardo, good question, ???, please see below and picture.

Password fields present on an insecure (http://) page. This is a security risk that allows user login credentials to be stolen.[Learn More] index.php
Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help http://xhr.spec.whatwg.org/ jquery.min-1e97c57a81acfd9a31e6fae3550c5f81.js:2:79417
This site appears to use a scroll-linked positioning effect. This may not work well with asynchronous panning; see https://developer.mozilla.org/docs/Mozilla/Performance/ScrollLinkedEffects for further details and to join the discussion on related tools and features!

On a second test the script files have been loaded.

Still the same problem: After changing the shortcut target and hitting close without saving, TYPO3 does not ask, if changes should be saved.

On other changes it works like expected.

Actions #7

Updated by Riccardo De Contardi over 5 years ago

all my scripts on that page have status code: 200

I also experience the warning:

jquery.js:9488

[Deprecation] Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.
Actions #8

Updated by Helmut Winkelbach over 5 years ago

The same with "Insert records"
After adding a record and hitting close without saving, TYPO3 does not ask, if changes should be saved.

Actions #9

Updated by Helmut Winkelbach over 5 years ago

There is 1 more, "Text & Images" if i edit in "source" mode and hitt close without saving, TYPO3 does not ask, if changes should be saved.

Actions #10

Updated by Andreas Krämer over 5 years ago

I also can not reproduce this with TYPO3 9.5.1 and changing the shortcut target.

But I am not asked to save my changes whenever removing a record from a multi select field. E.g. wehn I remove a static template from a sys_template record. I am not asked to save my changes when hitting "Close".

Actions #11

Updated by Riccardo De Contardi about 5 years ago

  • Category set to Backend JavaScript

@Helmut Winkelbach sorry for this late reply; Do you still experience the same error with saving the shortcut field? I am still unable to reproduce it, either on 10.0.0-dev (latest master).

Helmut Winkelbach wrote:

There is 1 more, "Text & Images" if i edit in "source" mode and hitt close without saving, TYPO3 does not ask, if changes should be saved.

This is reproducible, but it is another issue, I would ask you to fill a different issue for that, thank you!

Andreas Krämer wrote:

I also can not reproduce this with TYPO3 9.5.1 and changing the shortcut target.

But I am not asked to save my changes whenever removing a record from a multi select field. E.g. wehn I remove a static template from a sys_template record. I am not asked to save my changes when hitting "Close".

Andreas, also this one is a different issue :) please, I would kindly ask you to open another issue for this problem.

Actions #12

Updated by Riccardo De Contardi over 4 years ago

  • Related to Bug #88719: Close should recognize non-saved record - but fails added
Actions #13

Updated by Riccardo De Contardi over 4 years ago

  • Related to Bug #88875: Modal Page altered not shown everytime added
Actions #14

Updated by Gone With the Wind over 4 years ago

This problem is resolved. See https://forge.typo3.org/issues/88719

Actions #15

Updated by Riccardo De Contardi about 4 years ago

  • Status changed from Needs Feedback to Closed

I close this issue as resolved

But I am not asked to save my changes whenever removing a record from a multi select field. E.g. wehn I remove a static template from a sys_template record. I am not asked to save my changes when hitting "Close".

As far as I have seen this one has been resolved on version 9.5.14 - tested with both sys_template > include static from extension and editing a content > Usergroup access right

There is 1 more, "Text & Images" if i edit in "source" mode and hitt close without saving, TYPO3 does not ask, if changes should be saved.

This is still true but I'll open a new issue for this one.

Actions

Also available in: Atom PDF