Project

General

Profile

Actions

Bug #86712

closed

config.sys_language_overlay has no effect

Added by Philipp Seiler over 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
2018-10-22
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
localization,language,translation,config,query
Complexity:
Is Regression:
Sprint Focus:
On Location Sprint

Description

Hi,
the Typoscript setting config.sys_language_overlay seems to have no effect anymore with the new Context and LanguageAspect.

Even though LanguageAspect has a separate constructor parameter for setting the overlay type, it is actually never called with that parameter. Therefore always the fallback value of includeFloating is used. When setting the overlay mode for queries in repositories manually, the overlay works as intended.

There even is a LanguageAspectFactory which would take the Typoscript configuration into account, but that class is only used in the FrontendController.

Regard,
Philipp


Files

RequestMiddlewares.php (597 Bytes) RequestMiddlewares.php Sebastian Mazza, 2018-12-14 00:38
LanguageOverlayFixer.php (2.25 KB) LanguageOverlayFixer.php Sebastian Mazza, 2018-12-14 00:39

Related issues 2 (1 open1 closed)

Related to TYPO3 Core - Bug #86595: No Language FallbackClosedAnja Leichsenring2018-10-08

Actions
Related to TYPO3 Core - Bug #88367: Improve option names of "Fallback Type" in the sites configurationNew2019-05-16

Actions
Actions #1

Updated by Philipp Seiler over 5 years ago

  • Related to Bug #86595: No Language Fallback added
Actions #2

Updated by Tymoteusz Motylewski over 5 years ago

  • Category changed from Localization to Link Handling, Site Handling & Routing
Actions #3

Updated by Sven Juergens over 5 years ago

same problem here.

if I use SiteHandling I will no longer see translations in FreeMode regardless of language fallback modes

Actions #4

Updated by Sven Juergens over 5 years ago

For me it was about the standard output of tt_content elements.

"Problem" was that I got the content with the standard query styles.content.get. In that case there was no translated content in free mode, if SiteHandling was used.

if I extend the query of styles.content.get to
10 <styles.content.get
10.select.includeRecordsWithoutDefaultTranslation = 1

the output of tt_content works again...

maybe it will help other seekers

Actions #5

Updated by Philipp Seiler over 5 years ago

I've included content via the Typoscript CONTENT object (as far as I remember styles.content.get is just an alias for CONTENT), and it still doesn't work.

temp.content0 = CONTENT
temp.content0 {
    table = tt_content
    wrap = |
    select {
        where = colPos = 0
        orderBy = sorting
        languageField = sys_language_uid
        includeRecordsWithoutDefaultTranslation = 1
    }
}

Note: In my case I'm talking about News-Records, not standard tt_content. includeRecordsWithoutDefaultTranslation doesn't work for standard content elements for me either.

Maybe my page configuration is wrong?

config {
    sys_language_uid = 0
    sys_language_overlay = 1
    sys_language_mode = content_fallback;1,0
}

Actions #6

Updated by Susanne Moog over 5 years ago

  • Sprint Focus set to On Location Sprint
Actions #7

Updated by Sebastian Mazza over 5 years ago

I can confirm that the config.sys_language_overlay is totally useless in TYPO3 9.5 if a Site-Configuration (typo3conf/sites/xxxx) is used. => I'm not able to display any non translated tt_content record in the FE.

Updated by Sebastian Mazza over 5 years ago

As a workaround for this problem I have implemented a Middleware that sets the overlayType of the LanguageAspect to "mixed".

Actions #9

Updated by Gerrit Code Review about 5 years ago

  • Status changed from New to Under Review

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60367

Actions #10

Updated by Gerrit Code Review about 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60456

Actions #11

Updated by Benni Mack about 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #12

Updated by Benni Mack almost 5 years ago

  • Status changed from Resolved to Closed
Actions #13

Updated by Benni Mack over 2 years ago

  • Related to Bug #88367: Improve option names of "Fallback Type" in the sites configuration added
Actions

Also available in: Atom PDF