Bug #87612
closed
Content element sorting wrong when one element has sorting value of zero
100%
Description
When one content element has a sorting value of 0, pasting a new element on that column does not work correctly.
This can e.g. be triggered with gridelements (https://gitlab.com/coderscare/gridelements/issues/5)
Expectation: when one element has a sorting value of 0 and a new element should be inserted before this element, the element with value 0 should be included in re-numbering the sort values
Actual result: the element with sorting value of 0 will always be excluded from re-numbering, thus will always stay on top
Updated by Gerrit Code Review almost 6 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59604
Updated by Helmut Hummel almost 6 years ago
Actually, this can be reproduced without gridelements involved
- Create a new page
- Add 10 Elements to the page, by always adding the new elements before all already existing ones (always on top)
- Try to add an 11th Element on the top.
Expectation:
Element is added on the top
Actual result:
Element is inserted as second element
For a quicker test: Add one element and change the sorting value to 0 (which is what happens to the 10th element) and then try to add one element above the one that has sorting 0
Updated by Georg Dümmler over 5 years ago
The error also exists in a clean installation without any additional extension.
Your patch works too.
Can you speed it up somehow?
Updated by Riccardo De Contardi over 5 years ago
- Related to Bug #88051: Wrong CE order when copying pages with more than 10 CEs per column added
Updated by F Altrock over 5 years ago
- Has duplicate Bug #88696: DataHandler getSortNumber use of increaseSortingOfFollowing wrong added
Updated by Markus Klein over 5 years ago
- Category set to DataHandler aka TCEmain
- Assignee set to Markus Klein
- Priority changed from Should have to Must have
- Complexity set to medium
- Is Regression set to Yes
Updated by Gerrit Code Review over 5 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59604
Updated by Gerrit Code Review over 5 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59604
Updated by Gerrit Code Review over 5 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59604
Updated by Gerrit Code Review over 5 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59604
Updated by Helmut Hummel over 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 6717bd5f2032b21409340a3130647ba727507bd6.
Updated by Gerrit Code Review over 5 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61580
Updated by Gerrit Code Review over 5 years ago
Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61580
Updated by Helmut Hummel over 5 years ago
- Status changed from Under Review to Resolved
Applied in changeset 362f8fc97b425e615af715937cfd6fe288ba4ede.
Updated by Benni Mack almost 5 years ago
- Status changed from Resolved to Closed
Updated by Markus Klein over 4 years ago
- Related to Bug #87531: Sort sub pages results in wrong page order added