Bug #87612

Content element sorting wrong when one element has sorting value of zero

Added by Helmut Hummel 5 months ago. Updated 3 months ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2019-02-01
Due date:
% Done:

0%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When one content element has a sorting value of 0, pasting a new element on that column does not work correctly.

This can e.g. be triggered with gridelements (https://gitlab.com/coderscare/gridelements/issues/5)

Expectation: when one element has a sorting value of 0 and a new element should be inserted before this element, the element with value 0 should be included in re-numbering the sort values

Actual result: the element with sorting value of 0 will always be excluded from re-numbering, thus will always stay on top


Related issues

Related to TYPO3 Core - Bug #88051: Wrong CE order when copying pages with more than 10 CEs per column New 2019-04-02

History

#1 Updated by Gerrit Code Review 5 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59604

#2 Updated by Helmut Hummel 5 months ago

Actually, this can be reproduced without gridelements involved

  1. Create a new page
  2. Add 10 Elements to the page, by always adding the new elements before all already existing ones (always on top)
  3. Try to add an 11th Element on the top.

Expectation:

Element is added on the top

Actual result:

Element is inserted as second element

For a quicker test: Add one element and change the sorting value to 0 (which is what happens to the 10th element) and then try to add one element above the one that has sorting 0

#3 Updated by Georg Dümmler 3 months ago

The error also exists in a clean installation without any additional extension.

Your patch works too.
Can you speed it up somehow?

#4 Updated by Riccardo De Contardi 2 months ago

  • Related to Bug #88051: Wrong CE order when copying pages with more than 10 CEs per column added

Also available in: Atom PDF