Bug #87612

Content element sorting wrong when one element has sorting value of zero

Added by Helmut Hummel about 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
DataHandler aka TCEmain
Target version:
-
Start date:
2019-02-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
medium
Is Regression:
Yes
Sprint Focus:

Description

When one content element has a sorting value of 0, pasting a new element on that column does not work correctly.

This can e.g. be triggered with gridelements (https://gitlab.com/coderscare/gridelements/issues/5)

Expectation: when one element has a sorting value of 0 and a new element should be inserted before this element, the element with value 0 should be included in re-numbering the sort values

Actual result: the element with sorting value of 0 will always be excluded from re-numbering, thus will always stay on top


Related issues

Related to TYPO3 Core - Bug #88051: Wrong CE order when copying pages with more than 10 CEs per columnClosed2019-04-02

Actions
Related to TYPO3 Core - Bug #87531: Sort sub pages results in wrong page orderClosed2019-01-24

Actions
Has duplicate TYPO3 Core - Bug #88696: DataHandler getSortNumber use of increaseSortingOfFollowing wrongClosed2019-07-05

Actions
#1

Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59604

#2

Updated by Helmut Hummel about 2 years ago

Actually, this can be reproduced without gridelements involved

  1. Create a new page
  2. Add 10 Elements to the page, by always adding the new elements before all already existing ones (always on top)
  3. Try to add an 11th Element on the top.

Expectation:

Element is added on the top

Actual result:

Element is inserted as second element

For a quicker test: Add one element and change the sorting value to 0 (which is what happens to the 10th element) and then try to add one element above the one that has sorting 0

#3

Updated by Georg Dümmler almost 2 years ago

The error also exists in a clean installation without any additional extension.

Your patch works too.
Can you speed it up somehow?

#4

Updated by Riccardo De Contardi almost 2 years ago

  • Related to Bug #88051: Wrong CE order when copying pages with more than 10 CEs per column added
#5

Updated by F Altrock over 1 year ago

  • Has duplicate Bug #88696: DataHandler getSortNumber use of increaseSortingOfFollowing wrong added
#6

Updated by Markus Klein over 1 year ago

  • Category set to DataHandler aka TCEmain
  • Assignee set to Markus Klein
  • Priority changed from Should have to Must have
  • Complexity set to medium
  • Is Regression set to Yes
#7

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59604

#8

Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59604

#9

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59604

#10

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59604

#11

Updated by Helmut Hummel over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#12

Updated by Gerrit Code Review over 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61580

#13

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61580

#14

Updated by Helmut Hummel over 1 year ago

  • Status changed from Under Review to Resolved
#15

Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed
#16

Updated by Markus Klein 12 months ago

  • Related to Bug #87531: Sort sub pages results in wrong page order added

Also available in: Atom PDF