Bug #87612: Content element sorting wrong when one element has sorting value of zero - TYPO3 Core - TYPO3 Forge

Custom queries

12 LTS
Accessibility
Dashboard issues
Easy tasks
Extbase Issues
FAL Issues
FAL Sprint 2023
Hierarchical Issues
Issues reported for v11
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
Most wanted Bugfixes
Most wanted Features
My open issues
New & Unassigned
No feedback within 90 days
Open Bugs
Open issues of 10
Page Tree Regressions after 2020-07-28
Recently modified
Regressions
Stabilization Issues

Watchers (9)

Alexander Vogt
David Rellstab
Felix Jacobi
filigivuji filigivuji
Georg Dümmler
Sebastian Peine
Stephan Salzmann
Sven Nußbaum
Wittkiel Gruppe

Actions

Copy link

Bug #87612

closed

Content element sorting wrong when one element has sorting value of zero

Added by Helmut Hummel about 5 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Markus Klein

Category:

DataHandler aka TCEmain

Target version:

Start date:

2019-02-01

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

medium

Is Regression:

Yes

Sprint Focus:

Description

When one content element has a sorting value of 0, pasting a new element on that column does not work correctly.

This can e.g. be triggered with gridelements (https://gitlab.com/coderscare/gridelements/issues/5)

Expectation: when one element has a sorting value of 0 and a new element should be inserted before this element, the element with value 0 should be included in re-numbering the sort values

Actual result: the element with sorting value of 0 will always be excluded from re-numbering, thus will always stay on top

Related issues 3 (0 open — 3 closed)

Related to TYPO3 Core - Bug #88051: Wrong CE order when copying pages with more than 10 CEs per column

Closed

2019-04-02

Actions

Related to TYPO3 Core - Bug #87531: Sort sub pages results in wrong page order

Closed

2019-01-24

Actions

Has duplicate TYPO3 Core - Bug #88696: DataHandler getSortNumber use of increaseSortingOfFollowing wrong

Closed

2019-07-05

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Gerrit Code Review about 5 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59604

Actions

Copy link

Updated by Helmut Hummel about 5 years ago

Actually, this can be reproduced without gridelements involved

Create a new page
Add 10 Elements to the page, by always adding the new elements before all already existing ones (always on top)
Try to add an 11th Element on the top.

Expectation:

Element is added on the top

Actual result:

Element is inserted as second element

For a quicker test: Add one element and change the sorting value to 0 (which is what happens to the 10th element) and then try to add one element above the one that has sorting 0

Actions

Copy link

Updated by Georg Dümmler about 5 years ago

The error also exists in a clean installation without any additional extension.

Your patch works too.
Can you speed it up somehow?

Actions

Copy link

Updated by Riccardo De Contardi about 5 years ago

Related to Bug #88051: Wrong CE order when copying pages with more than 10 CEs per column added

Actions

Copy link

Updated by F Altrock almost 5 years ago

Has duplicate Bug #88696: DataHandler getSortNumber use of increaseSortingOfFollowing wrong added

Actions

Copy link

Updated by Markus Klein over 4 years ago

Category set to DataHandler aka TCEmain
Assignee set to Markus Klein
Priority changed from Should have to Must have
Complexity set to medium
Is Regression set to Yes

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59604

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59604

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59604

Actions

Copy link

#10

Updated by Gerrit Code Review over 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59604

Actions

Copy link

#11

Updated by Helmut Hummel over 4 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 6717bd5f2032b21409340a3130647ba727507bd6.

Actions

Copy link

#12

Updated by Gerrit Code Review over 4 years ago

Status changed from Resolved to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61580

Actions

Copy link

#13

Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61580

Actions

Copy link

#14