Project

General

Profile

Actions

Bug #88171

closed

Latest symfony/routing release breaks Core

Added by Andreas Kienast over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2019-04-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
nightmare
Is Regression:
Sprint Focus:

Description

The latest release of symfony/routing introduced a fix regarding trailing slashes, which breaks our current code base.


Related issues 3 (0 open3 closed)

Related to TYPO3 Core - Bug #88199: Redirect endless Loop on root pageClosed2019-04-24

Actions
Has duplicate TYPO3 Core - Bug #88177: Upgrading symfony routing causes endless redirectsClosed2019-04-19

Actions
Has duplicate TYPO3 Core - Bug #88188: Empty slug in page translations causes page not found error 404Closed2019-04-23

Actions
Actions #1

Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60509

Actions #2

Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60509

Actions #3

Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60509

Actions #4

Updated by Gerrit Code Review over 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60509

Actions #5

Updated by Gerrit Code Review over 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60509

Actions #6

Updated by Gerrit Code Review over 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60509

Actions #7

Updated by Gerrit Code Review over 5 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60509

Actions #8

Updated by Gerrit Code Review over 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60517

Actions #9

Updated by Anonymous over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Georg Ringer over 5 years ago

  • Has duplicate Bug #88177: Upgrading symfony routing causes endless redirects added
Actions #11

Updated by Christian Spoo over 5 years ago

How about using \Symfony\Component\Routing\Matcher\RedirectableUrlMatcher instead of \Symfony\Component\Routing\Matcher\UrlMatcher, rather than downgrading symfony/routing? This will enable $supportsTrailingSlash inside the routing logic and thus allow the SiteMatcher to use site prefixes with trailing slashes.
At first glance this should fix the problem although I haven't thoroughly tested all cases.

Actions #12

Updated by Susanne Moog over 5 years ago

The issue is already fixed on symfony side and will probably be included in the next release: https://github.com/symfony/symfony/pull/31107#issuecomment-484681404

Actions #13

Updated by Riccardo De Contardi over 5 years ago

  • Related to Bug #88199: Redirect endless Loop on root page added
Actions #14

Updated by Susanne Moog over 5 years ago

  • Has duplicate Bug #88188: Empty slug in page translations causes page not found error 404 added
Actions #15

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF