Project

General

Profile

Actions

Bug #88836

closed

page type not respected under some circumstances

Added by Chris Müller almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
2019-07-24
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:
On Location Sprint

Description

In the site configuration I have the following configuration:

...
routeEnhancers:
  Suffix:
    type: PageType
    default: /
    index: ''
    map:
      /: 0
      yoast-snippetpreview.json: 1480321830
...

When I now generate the XML index sitemap (with type 1533906435) I don't get the type in the sitemap URLs, so the link shows the home page instead of the pages XML sitemap:

<sitemap>
  <loc>https://website.ddev.local:8443/de/?sitemap=pages&amp;cHash=0fe835841492c3b52e6090c6a7f6f310</loc>
  <lastmod>2019-07-24T09:30:35+02:00</lastmod>
</sitemap>

But if I remove the routeEnhances.Suffix part, the type is respected:

<sitemap>
  <loc>https://website.ddev.local:8443/de/?sitemap=pages&amp;type=1533906435&amp;cHash=0fe835841492c3b52e6090c6a7f6f310</loc>
  <lastmod>2019-07-24T09:30:35+02:00</lastmod>
</sitemap>

Related issues 5 (1 open4 closed)

Related to TYPO3 Core - Bug #87817: PageLinkBuilder fails adding pagetype parameter, if routeEnhancers for PageTypeSuffix is definedClosed2019-03-01

Actions
Related to TYPO3 Core - Bug #87016: Seo sitemap does not note routeEnhancer on extensionsClosed2018-11-27

Actions
Related to TYPO3 Core - Bug #86835: Static route sitemap.xml is still not working on single-page treeNew2018-11-02

Actions
Related to TYPO3 Core - Bug #87155: Strange link building when having several page types configuredClosed2018-12-13

Actions
Related to TYPO3 Core - Bug #87104: PageTypeSuffix removes type parameter for non mapped type valuesClosed2018-12-07

Actions
Actions #1

Updated by Susanne Moog almost 5 years ago

  • Status changed from New to Needs Feedback

As far as I understood, as soon as you have one type mapped via site handling, all used types need to be mapped to work. Can you please try to add the mapping for the sitemap type `1533906435`, too?

Actions #2

Updated by Chris Müller almost 5 years ago

You are right, when one type is mapped, other types must also be added.

When I add the sitemap type, it works:

routeEnhancers:
  Suffix:
    type: PageType
    default: /
    index: ''
    map:
      /: 0
      yoast-snippetpreview.json: 1480321830
      sitemap.xml: 1533906435
Actions #3

Updated by Riccardo De Contardi almost 5 years ago

@Chris Müller thank you for your answer; do you think that this issue can be closed, or is there still something to do about this topic? Thank you.

Actions #4

Updated by Chris Müller almost 5 years ago

As far as I see: If you map one type to the site configuration, alls types must be mapped - otherwise for the not mapped types the links are not created correctly (the type parameter is missing). So, yes, it's a bug.

Actions #5

Updated by Riccardo De Contardi almost 5 years ago

  • Status changed from Needs Feedback to New
Actions #6

Updated by Tymoteusz Motylewski over 4 years ago

  • Related to Bug #87817: PageLinkBuilder fails adding pagetype parameter, if routeEnhancers for PageTypeSuffix is defined added
Actions #7

Updated by Tymoteusz Motylewski over 4 years ago

  • Related to Bug #87016: Seo sitemap does not note routeEnhancer on extensions added
Actions #8

Updated by Tymoteusz Motylewski over 4 years ago

  • Related to Bug #86835: Static route sitemap.xml is still not working on single-page tree added
Actions #9

Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62383

Actions #10

Updated by Susanne Moog over 4 years ago

  • Sprint Focus set to On Location Sprint
Actions #11

Updated by Markus Klein over 4 years ago

  • Related to Bug #87155: Strange link building when having several page types configured added
Actions #12

Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62383

Actions #13

Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62811

Actions #14

Updated by Benni Mack over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #15

Updated by Benni Mack over 4 years ago

  • Status changed from Resolved to Closed
Actions #16

Updated by Benni Mack over 4 years ago

  • Related to Bug #87104: PageTypeSuffix removes type parameter for non mapped type values added
Actions

Also available in: Atom PDF