Project

General

Profile

Actions

Bug #89348

closed

EXT:core has hidden dependency on EXT:frontend (circular dependency)

Added by Claus Due about 5 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Start date:
2019-10-04
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In ext_tables.php of EXT:core, classes from EXT:frontend are used. However, EXT:frontend is not declared as dependency of EXT:core (since this would create a circular dependency).

The problem is usage of class constants from a class that does not exist without EXT:frontend installed.

Suggest moving these constants to EXT:core (since they relate to "pages" table which is supposed to be operable even without EXT:frontend installed and is fully declared as SQL in EXT:core).

Actions #1

Updated by Frank Nägler about 5 years ago

  • Status changed from New to Needs Feedback

I guess you mean PageRepository::DOKTYPE_* ?
This class is moved into core for v10. I guess this must not be fixed in v9 or is this a pressing issue?

Actions #2

Updated by Claus Due almost 5 years ago

IMHO this would still need to be fixed/backported to v9. There's another case that was fixed recently in EXT:extbase - https://github.com/TYPO3/TYPO3.CMS/commit/49dcd95090faffb7931131348c6d9ac17428998f

Until this is fixed in v9 the circular dependency still exists therein.

Actions #3

Updated by Riccardo De Contardi almost 5 years ago

  • Status changed from Needs Feedback to New
Actions #4

Updated by Christian Eßl over 4 years ago

  • Category set to Code Cleanup
Actions #5

Updated by Georg Ringer over 4 years ago

  • Status changed from New to Accepted
  • Target version set to Candidate for Major Version
Actions #6

Updated by Susanne Moog over 4 years ago

For version 9 I would not fix that. Both core and frontend are marked as "partOfMinimalUsableSystem" - so circular dependency or not, we are clearly stating that the system won't work if one of them isn't there.

Actions #7

Updated by Christian Kuhn about 2 years ago

  • Status changed from Accepted to Closed

Closing: There are no constants from ext:frontend used in ext:core ext_localconf.php anymore.

Actions

Also available in: Atom PDF