Bug #89578
closed
Redirect migration wizard creates wrong redirects
Added by Matthias Krappitz about 5 years ago.
Updated almost 3 years ago.
Description
When updating from TYPO3 8 to 9 and when having domain records with redirects for example for redirecting a subdomain without www to the one with www, the update migration wizard 'Install system extension "redirects" if a sys_domain entry with redirectTo is necessary' creates wrong redirects.
For example if you had a domain record in 8 for domain "test.com" having the redirect target "https://www.test.com/", the migration wizard creates a redirect with an empty source domain and the source path "/test.com/", which is not correct. It should have been source domain "test.com" and source path "/". When correcting this manually after the upgrade wizard, it works fine.
- Description updated (diff)
- Category set to Install Tool
This problem still exists in TYPO3 10.4.1. I would consider this a problem with priority Must have. Core migration wizards should be reliable to run as far as possible.
I could confirm the issue.
The $sourceDetails is generated with parse_url. If the domain is like test.com, it will be extracted as path.
This fix our situation:
diff -r a/typo3/sysext/install/Classes/Updates/RedirectsExtensionUpdate.php b/typo3/sysext/install/Classes/Updates/RedirectsExtensionUpdate.php
172a173,174
> $sourceDetails['host'] = $domainName;
> $sourceDetails['path'] = str_replace($domainName, '', $sourceDetails['path']);
To fix this bug change $sourceDetails = parse_url($domainName); to $sourceDetails = parse_url('//' . $domainName); in sysext/install/Classes/Updates/RedirectsExtensionUpdate.php. As the domain name of a domain record must not start with a scheme and/or double slashes the domain name must be prefixed with double slashes in the parse_url call to recognize the domain name as host and not as path. See Example #2 A parse_url() example with missing scheme in PHP documentation.
- Related to Bug #91780: RedirectsExtensionUpdate Upgrade Wizard parse_url is buggy added
Can be closed. Bug is fixed with #91780.
- Status changed from New to Closed
I close this issue for now.
If you think that this is the wrong decision or experience the issue again, please reopen it or ping me.
Thanks
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by 
Updated by 
Updated by