Bug #89871
closed
Epic #89797: HrefLang / Canonical issues
HrefLangGenerator: Wrong links generated with page translations that use a shortcut
100%
Description
Steps to reproduce:
- Create a site config with the languages "*Default*", "*German*", "*Spanish*"
- Create a page "Page A" and translate it to all languages
- Create a page "Page B" and translate it to all languages
- On "Page A", make the german translation to a "Shortcut" to "Page B"
- Now open the spanish version of "Page A".
Expected:
- The hreflang for "de" looks like https://www.sitename.com/de/page-b
Actual:
- The hreflang for "de" now looks like https://www.sitename.com/es/page-b
- This will also easily result in a 404 error, if the page title is different in the translation.
The HreflangGenerator incorrectly uses the language parameter of the current language instead of the one of the target language, if shortcuts are used.
Updated by Christian Eßl over 4 years ago
Found the reason:
https://github.com/TYPO3/TYPO3.CMS/commit/8d61bef0865649bbe3d73bdf77a47c760c8d9ba4
In this commit, shortcut pages are now generated with the setting "'language' => 'current',", which overrides the L parameter.
Updated by Gerrit Code Review over 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552
Updated by Mathias Brodala over 4 years ago
- Related to Bug #81657: TSFE->page contains default language page when content_fallback; 1,0 is used added
Updated by Mathias Brodala over 4 years ago
- Related to Bug #86595: No Language Fallback added
Updated by Mathias Brodala over 4 years ago
- Related to Bug #19114: sys_language_mode content_fallback with a defined fallback chain does not output expected fallback content added
Updated by Gerrit Code Review over 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552
Updated by Susanne Moog over 4 years ago
- Sprint Focus set to On Location Sprint
Updated by Gerrit Code Review about 4 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552
Updated by Gerrit Code Review about 4 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552
Updated by Gerrit Code Review about 4 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552
Updated by Gerrit Code Review about 4 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552
Updated by Gerrit Code Review almost 4 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552
Updated by Gerrit Code Review almost 4 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552
Updated by
Updated by Gerrit Code Review over 3 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552
Updated by Gerrit Code Review over 3 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552
Updated by Gerrit Code Review about 3 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67696
Updated by Christian Eßl about 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 65dc0603115ee7a70148c2d6fb095102e8f51a39.
Updated by
Updated by Nikita Hovratov over 2 years ago
- Related to Bug #94677: Menu-item of type "shortcut" is language-overlayed twice added
Updated by Nikita Hovratov over 2 years ago
- Related to Task #95966: Wrong tests for #89871 added