Bug #81657

TSFE->page contains default language page when content_fallback; 1,0 is used

Added by Tymoteusz Motylewski almost 2 years ago. Updated 15 days ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Localization
Target version:
-
Start date:
2017-06-21
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Given:
- I'm requesting L=2 (German)
- The page is NOT translated to German (2), but IS to Dutch (1)
- config.sys_language_mode = content_fallback;1,0

Expected:
- GLOBALS['tsfe']->page['title'] should show Dutch page title

Actual:
- it shows default language title


Related issues

Related to TYPO3 Core - Bug #17354: fallback for menus. "content_fallback;1,0" has no affect for page records (e.g. menu) Closed 2007-07-22
Related to TYPO3 Core - Bug #19114: sys_language_mode content_fallback with a defined fallback chain does not output expected fallback content Closed 2008-07-16

Associated revisions

Revision 8d61bef0 (diff)
Added by Andreas Fernandez 3 months ago

[BUGFIX] Fix fallback language handling

This commit solves some issues regarding language fallback handling:

- Resolve correct page for a localized variant respecting fallbacks
The Page Router now respects the configured language fallback chain
and tries to find a matching page candidate per language.

- Metadata of page (e.g. page title)
TSFE now respects the reconfigured language content id in case the
language fallback is active and resolves the correct data.

- Respect existing localizations in menu rendering
PageRepository, used by the menu, now respects the language fallback
chain and finds suitable localized pages.
However, this does not resolve all issues with shortcut pages.

Resolves: #81657
Resolves: #86595
Resolves: #19114
Releases: master, 9.5
Change-Id: Ic2b302989449ec14e7e6b5c54819870770655da9
Reviewed-on: https://review.typo3.org/c/59676
Tested-by: TYPO3com <>
Tested-by: Ralf Merz <>
Tested-by: Anja Leichsenring <>
Tested-by: Benni Mack <>
Reviewed-by: Ralf Merz <>
Reviewed-by: Anja Leichsenring <>
Reviewed-by: Benni Mack <>

Revision 1d19ad35 (diff)
Added by Andreas Fernandez 3 months ago

[BUGFIX] Fix fallback language handling

This commit solves some issues regarding language fallback handling:

- Resolve correct page for a localized variant respecting fallbacks
The Page Router now respects the configured language fallback chain
and tries to find a matching page candidate per language.

- Metadata of page (e.g. page title)
TSFE now respects the reconfigured language content id in case the
language fallback is active and resolves the correct data.

- Respect existing localizations in menu rendering
PageRepository, used by the menu, now respects the language fallback
chain and finds suitable localized pages.
However, this does not resolve all issues with shortcut pages.

Resolves: #81657
Resolves: #86595
Resolves: #19114
Releases: master, 9.5
Change-Id: Ic2b302989449ec14e7e6b5c54819870770655da9
Reviewed-on: https://review.typo3.org/c/59845
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Benni Mack almost 2 years ago

  • Related to Bug #17354: fallback for menus. "content_fallback;1,0" has no affect for page records (e.g. menu) added

#2 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53307

#3 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53307

#4 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53307

#5 Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53307

#6 Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53307

#7 Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53307

#8 Updated by Susanne Moog over 1 year ago

  • Category set to Localization

#9 Updated by Sebastian Schmal about 1 year ago

  • Priority changed from Should have to Must have
  • TYPO3 Version changed from 7 to 8

Tymoteusz Motylewski wrote:

Given:
- I'm requesting L=2 (German)
- The page is NOT translated to German (2), but IS to Dutch (1)
- config.sys_language_mode = content_fallback;1,0

Expected:
- GLOBALS['tsfe']->page['title'] should show Dutch page title

Actual:
- it shows default language title

Dont works for TYPO3 8.7.10

config.sys_language_mode = content_fallback;1

all the Time, is the default/id=0 a fallback for the menu and tx_news! :(
After 10 the menu dont works for sys_language_mode = content_fallback; 1 in TYPO3 8.7.10
AFTER 10 years :D

#10 Updated by Tobias Jeske about 1 year ago

Is anyone working on this? :(

#11 Updated by Markus Klein 9 months ago

  • Status changed from Under Review to New

#12 Updated by Jo Hasenau 8 months ago

  • Related to Bug #19114: sys_language_mode content_fallback with a defined fallback chain does not output expected fallback content added

#13 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59676

#14 Updated by Gerrit Code Review 3 months ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59676

#15 Updated by Gerrit Code Review 3 months ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59676

#16 Updated by Gerrit Code Review 3 months ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59676

#17 Updated by Gerrit Code Review 3 months ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59676

#18 Updated by Gerrit Code Review 3 months ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59676

#19 Updated by Gerrit Code Review 3 months ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59676

#20 Updated by Gerrit Code Review 3 months ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59676

#21 Updated by Gerrit Code Review 3 months ago

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59676

#22 Updated by Gerrit Code Review 3 months ago

Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59676

#23 Updated by Gerrit Code Review 3 months ago

Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59676

#24 Updated by Gerrit Code Review 3 months ago

Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59676

#25 Updated by Gerrit Code Review 3 months ago

Patch set 25 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59676

#26 Updated by Gerrit Code Review 3 months ago

Patch set 26 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59676

#27 Updated by Gerrit Code Review 3 months ago

Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59676

#28 Updated by Gerrit Code Review 3 months ago

Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59676

#29 Updated by Gerrit Code Review 3 months ago

Patch set 29 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59676

#30 Updated by Gerrit Code Review 3 months ago

Patch set 30 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59676

#31 Updated by Gerrit Code Review 3 months ago

Patch set 31 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59676

#32 Updated by Gerrit Code Review 3 months ago

Patch set 32 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59676

#33 Updated by Gerrit Code Review 3 months ago

Patch set 33 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59676

#34 Updated by Gerrit Code Review 3 months ago

Patch set 34 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59676

#35 Updated by Gerrit Code Review 3 months ago

Patch set 35 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59676

#36 Updated by Gerrit Code Review 3 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59845

#37 Updated by Andreas Fernandez 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#38 Updated by Benni Mack 15 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF