Feature #90068

Implement better FileDumpController

Added by Stefan Froemken over 1 year ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Category:
Image Generation / GIFBUILDER
Start date:
2020-01-08
Due date:
% Done:

100%

Estimated time:
PHP Version:
7.3
Tags:
Complexity:
easy
Sprint Focus:

Description

Hello,

I miss some options in FileDumpController like fetching sys_file_references, setting width/height or applying cropVariants.

Stefan


Related issues

Related to TYPO3 Core - Bug #93024: PDF download from private storage yields thumbnailClosed2020-12-08

Actions
Related to TYPO3 Core - Bug #93410: The download of pdf files via privatestorage/eID returns an imageClosed2021-02-02

Actions
Related to TYPO3 Core - Bug #93501: FileDump return an image instead of pdfClosed2021-02-12

Actions
#1

Updated by Georg Ringer over 1 year ago

  • Target version changed from next-patchlevel to Candidate for Major Version
#2

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62831

#3

Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62834

#4

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62834

#5

Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62834

#6

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62834

#7

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62834

#8

Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62834

#9

Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62834

#10

Updated by Gerrit Code Review over 1 year ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62834

#11

Updated by Gerrit Code Review over 1 year ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62834

#12

Updated by Gerrit Code Review over 1 year ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62834

#13

Updated by Stefan Froemken over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#14

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed
#15

Updated by Sebastian Michaelsen 8 months ago

  • Related to Bug #93024: PDF download from private storage yields thumbnail added
#16

Updated by Altan Tosun 6 months ago

  • Related to Bug #93410: The download of pdf files via privatestorage/eID returns an image added
#17

Updated by Altan Tosun 6 months ago

  • Status changed from Closed to New

This change breaks eID file download – see: https://forge.typo3.org/issues/93410?next_issue_id=93409

First of all, all files are being processed. For example PDF's are not downadable anymore, instead you get an image. High-resolution images are also processed which is not intended. Cropping must be all the time explicit and choosable. We should not have any magic functions which does unexpected behaviour.

#18

Updated by Georg Ringer 5 months ago

  • Related to Bug #93501: FileDump return an image instead of pdf added
#19

Updated by Georg Ringer 5 months ago

  • Status changed from New to Closed

issue is closed and should be closed, please always create new issues.

Also available in: Atom PDF