Project

General

Profile

Actions

Bug #90919

closed

Overridden subject in EmailFinisher not used

Added by Chris Müller over 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2020-04-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:
Remote Sprint

Description

The default subject of an email form finisher is defined in a locallang.xlf file and thereby localizable:


<trans-unit id="<formIdentifier>.finisher.EmailToReceiver.subject">
<source><![CDATA[Some subject]]></source>
</trans-unit>

Now the subject is overridden in the form plugin:

When sending the form, the subject of the email is still "Some subject" instead of "Another subject".


Files

form-override-subject.png (12.2 KB) form-override-subject.png Chris Müller, 2020-04-01 14:11

Related issues 3 (1 open2 closed)

Related to TYPO3 Core - Bug #92408: TypoScript overrides does not work when using ViewHelperClosed2020-09-25

Actions
Related to TYPO3 Core - Bug #97502: Drop extension scanner tag in RST of #90919Closed2022-04-28

Actions
Related to TYPO3 Core - Task #97905: Add new feature 90919 - "Skip translation of overridden form finisher options" to form documentationAccepted2022-07-12

Actions
Actions #1

Updated by Björn Jacob over 3 years ago

  • Sprint Focus set to Remote Sprint
Actions #2

Updated by Björn Jacob over 2 years ago

  • TYPO3 Version changed from 9 to 11

We have to check if this is still valid.

Actions #3

Updated by Björn Jacob over 2 years ago

  • Status changed from New to In Progress
Actions #4

Updated by Björn Jacob over 2 years ago

  • Status changed from In Progress to New
Actions #5

Updated by Elias Häußler almost 2 years ago

I can reproduce this with current main.

The current translation order is:

  1. Default value from form definition
  2. Overridden value from flexform (if any)
  3. Localized value provided by translation files (if any)

Note that this order affects all finisher options, so it's more a general question: What's the expected translation order for finisher options?

Actions #6

Updated by Elias Häußler almost 2 years ago

  • Related to Bug #92408: TypoScript overrides does not work when using ViewHelper added
Actions #7

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions #8

Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions #9

Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions #10

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions #11

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions #12

Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions #13

Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions #14

Updated by Gerrit Code Review over 1 year ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions #15

Updated by Gerrit Code Review over 1 year ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions #16

Updated by Gerrit Code Review over 1 year ago

Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions #17

Updated by Gerrit Code Review over 1 year ago

Patch set 11 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions #18

Updated by Gerrit Code Review over 1 year ago

Patch set 12 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions #19

Updated by Gerrit Code Review over 1 year ago

Patch set 13 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions #20

Updated by Gerrit Code Review over 1 year ago

Patch set 14 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions #21

Updated by Anonymous over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #22

Updated by Elias Häußler over 1 year ago

  • Related to Bug #97502: Drop extension scanner tag in RST of #90919 added
Actions #23

Updated by Sybille Peters over 1 year ago

  • Related to Task #97905: Add new feature 90919 - "Skip translation of overridden form finisher options" to form documentation added
Actions #24

Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF