Bug #90919: Overridden subject in EmailFinisher not used - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #90919

closed

Overridden subject in EmailFinisher not used

Added by Chris Müller over 4 years ago. Updated about 2 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Form Framework

Target version:

Start date:

2020-04-01

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Remote Sprint

Description

The default subject of an email form finisher is defined in a locallang.xlf file and thereby localizable:

<trans-unit id="<formIdentifier>.finisher.EmailToReceiver.subject"> <source><![CDATA[Some subject]]></source> </trans-unit>

Now the subject is overridden in the form plugin:

When sending the form, the subject of the email is still "Some subject" instead of "Another subject".

Files

form-override-subject.png (12.2 KB) form-override-subject.png

Chris Müller, 2020-04-01 14:11

Related issues 3 (1 open — 2 closed)

Actions

Copy link

Updated by Björn Jacob over 4 years ago

Sprint Focus set to Remote Sprint

Actions

Copy link

Updated by Björn Jacob over 3 years ago

TYPO3 Version changed from 9 to 11

We have to check if this is still valid.

Actions

Copy link

Updated by Björn Jacob over 3 years ago

Status changed from New to In Progress

Actions

Copy link

Updated by Björn Jacob over 3 years ago

Status changed from In Progress to New

Actions

Copy link

Updated by Elias Häußler over 2 years ago

I can reproduce this with current main.

The current translation order is:

Default value from form definition
Overridden value from flexform (if any)
Localized value provided by translation files (if any)

Note that this order affects all finisher options, so it's more a general question: What's the expected translation order for finisher options?

Actions

Copy link

Updated by Elias Häußler over 2 years ago

Related to Bug #92408: TypoScript overrides does not work when using ViewHelper added

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions

Copy link

#10

Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions

Copy link

#11

Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions

Copy link

#12

Updated by Gerrit Code Review over 2 years ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions

Copy link

#13

Updated by Gerrit Code Review over 2 years ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions

Copy link

#14

Updated by Gerrit Code Review over 2 years ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions

Copy link

#15

Updated by Gerrit Code Review over 2 years ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions

Copy link

#16

Updated by Gerrit Code Review over 2 years ago

Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions

Copy link

#17

Updated by Gerrit Code Review over 2 years ago

Patch set 11 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions

Copy link

#18

Updated by Gerrit Code Review over 2 years ago

Patch set 12 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions

Copy link

#19

Updated by Gerrit Code Review over 2 years ago

Patch set 13 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions

Copy link

#20

Updated by Gerrit Code Review over 2 years ago

Patch set 14 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683

Actions

Copy link

#21