Bug #91792
open
Automatically created redirects are not created using the DataHandler
Added by Oliver Eglseder over 4 years ago.
Updated about 1 year ago.
Category:
Site Handling, Site Sets & Routing
Description
Method this is about: \TYPO3\CMS\Redirects\Service\SlugService::createRedirect
Redirects created when a page slug was updated are directly written to the database via DBAL instead of the DataHandler ("DH").
This has following drawbacks:
- There is no access check. Redirects are created even if the user is not allowed to create redirects.
- You can not use any hook to intercept, alter or get notfied of the redirect creation
- The sys_history entry is written by a different function than the DH would use. The manual implementation might be forgotten when changes are made to DH's implementation
- You have no way of knowing the uid of the created redirect to do something with it after the creation.
Actions done by backend users should always be processed by the DH.
There is no access check. Redirects are created even if the user is not allowed to create redirects.
And this gets even worse: after a redirect is automatically created, the info popup offers to revert the created redirects.
But since this now uses the RecordHistory, the redirects can not be removed due to missing access rights.
- Related to Bug #91751: Redirects are not tied to site configuation breaking referential integrity and making it impossible to test on/transfer from staging systems added
- Related to Bug #91936: Documentation missing to disable automatic creation of redirects on slug change added
As far as I can tell, when a new redirect is added, the redirect cache isn't cleared either. This causes a 404 until the frontend cache is cleared.
Richard Vollebregt wrote:
As far as I can tell, when a new redirect is added, the redirect cache isn't cleared either. This causes a 404 until the frontend cache is cleared.
This is true too
- Related to Feature #92004: Create redirect entry if updated slug is published to live added
- Related to Task #89301: Streamline automatic slug & redirects handling added
- Related to Task #90143: Redirects: Poor performance of redirect matching for large redirects table added
- Related to Bug #95272: Redirect after page slug change ignores TCA defaults added
- Sprint Focus set to On Location Sprint
- Sprint Focus deleted (
On Location Sprint)
Also available in: Atom
PDF