Bug #91885
closed
Page-Tree filter does not reset
0%
Description
You enter a filter-term in the page-tree filter input. you hit the explicit enter (yikes).
The page tree is filtered now (no info about the active filter - but thats another issue)
Now clear the whole filter-term from the filter-input-field. Just remove it with backspace, DEL or whatever you like to clear input-fields. until the field is empty (no chars left) and the placeholder shows again.
Expected result:
Applied filter is removed
Actual result:
Filter still active
TYPO3 10.4.6
Files
Updated by Anonymous over 3 years ago
- Related to Epic #88474: Page tree performance in 9.5 added
Updated by Anonymous over 3 years ago
- Related to Bug #91884: Page tree filter has no delete "X", needs hitting enter and has no filter info box anymore, a big backwards step regarding usability added
Updated by Kai Strecker over 3 years ago
The cause for this bug is this line:
https://github.com/TYPO3/TYPO3.CMS/blob/v10.4.6/typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeToolbar.js#L174
jQuery.fn.get returns a dom element, not a jQuery object.
To fix the bug, the line has to be changed from
let input = $submenu.find('input').get(0);
to
let input = $submenu.find('input').first();
Updated by Andreas Kienast over 3 years ago
- Status changed from New to Needs Feedback
I fail to reproduce the issue. Which browser do you use? Or is this related to the "I have to press Enter" issue?
Updated by Anonymous over 3 years ago
Andreas Fernandez wrote:
I fail to reproduce the issue. Which browser do you use? Or is this related to the "I have to press Enter" issue?
Version 84.0.4147.89
Updated by Anonymous over 3 years ago
Ingo Fabbri wrote:
Andreas Fernandez wrote:
I fail to reproduce the issue. Which browser do you use? Or is this related to the "I have to press Enter" issue?
Version 84.0.4147.89
Same in Firefox.
Updated by Anonymous over 3 years ago
- File Untitled.png Untitled.png added
Ingo Fabbri wrote:
Andreas Fernandez wrote:
I fail to reproduce the issue. Which browser do you use? Or is this related to the "I have to press Enter" issue?
Version 84.0.4147.89
Just don't hit enter. Remove the characters to empty the field.
until it looks like in the attachment
I think you can't expect people to hit enter on an empty field, just to make it do a reset.
Updated by Andreas Kienast over 3 years ago
So this is related to the issue I already created a patch for. Thanks, so I can link the issues.
Updated by Andreas Kienast over 3 years ago
- Related to Bug #91891: Page tree should auto filter added
Updated by Gerrit Code Review over 3 years ago
- Status changed from Needs Feedback to Under Review
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65138
Updated by Gerrit Code Review over 3 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65140
Updated by Anja Leichsenring over 3 years ago
- Related to Bug #88943: Pagetree taking extremely long to load for editors added
Updated by Anja Leichsenring over 3 years ago
- Related to Bug #88098: Page tree XHR is fetching huge JSON data added
Updated by Anja Leichsenring over 3 years ago
- Related to Bug #88259: Filtered pagetree should display child pages added
Updated by Andreas Kienast over 3 years ago
- Status changed from Under Review to Rejected
The page tree patch has been reverted and gets revised now: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65208