Bug #91885: Page-Tree filter does not reset - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Watchers (2)

Kai Strecker
Sybille Peters

Actions

Copy link

Bug #91885

closed

Page-Tree filter does not reset

Added by Anonymous over 4 years ago. Updated over 4 years ago.

Status:

Rejected

Priority:

Should have

Assignee:

Category:

Pagetree

Target version:

Start date:

2020-07-29

Due date:

% Done:

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Yes

Sprint Focus:

Description

You enter a filter-term in the page-tree filter input. you hit the explicit enter (yikes).

The page tree is filtered now (no info about the active filter - but thats another issue)

Now clear the whole filter-term from the filter-input-field. Just remove it with backspace, DEL or whatever you like to clear input-fields. until the field is empty (no chars left) and the placeholder shows again.

Expected result:

Applied filter is removed

Actual result:

Filter still active

TYPO3 10.4.6

Files

Untitled.png (3.95 KB) Untitled.png

Anonymous, 2020-07-29 14:29

Related issues 6 (0 open — 6 closed)

Related to TYPO3 Core - Epic #88474: Page tree performance in 9.5

Closed

2018-11-16

Actions

Related to TYPO3 Core - Bug #91884: Page tree filter has no delete "X", needs hitting enter and has no filter info box anymore, a big backwards step regarding usability

Closed

2020-07-29

Actions

Related to TYPO3 Core - Bug #91891: Page tree should auto filter

Rejected

Andreas Kienast

2020-07-29

Actions

Related to TYPO3 Core - Bug #88943: Pagetree taking extremely long to load for editors

Closed

2019-08-09

Actions

Related to TYPO3 Core - Bug #88098: Page tree XHR is fetching huge JSON data

Closed

2019-04-06

Actions

Related to TYPO3 Core - Bug #88259: Filtered pagetree should display child pages

Closed

2019-05-03

Actions

Issue # Delay: days Cancel

History
Notes
Property changes

Actions

Copy link

Updated by Anonymous over 4 years ago

Related to Epic #88474: Page tree performance in 9.5 added

Actions

Copy link

Updated by Anonymous over 4 years ago

Related to Bug #91884: Page tree filter has no delete "X", needs hitting enter and has no filter info box anymore, a big backwards step regarding usability added

Actions

Copy link

Updated by Kai Strecker over 4 years ago

The cause for this bug is this line:
https://github.com/TYPO3/TYPO3.CMS/blob/v10.4.6/typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeToolbar.js#L174

jQuery.fn.get returns a dom element, not a jQuery object.

To fix the bug, the line has to be changed from

let input = $submenu.find('input').get(0);

let input = $submenu.find('input').first();

Actions

Copy link

Updated by Andreas Kienast over 4 years ago

Status changed from New to Needs Feedback

I fail to reproduce the issue. Which browser do you use? Or is this related to the "I have to press Enter" issue?

Actions

Copy link

Updated by Anonymous over 4 years ago

Andreas Fernandez wrote:

I fail to reproduce the issue. Which browser do you use? Or is this related to the "I have to press Enter" issue?

Version 84.0.4147.89

https://www.whatsmybrowser.org/b/J4PON

Actions

Copy link

Updated by Anonymous over 4 years ago

Ingo Fabbri wrote:

Andreas Fernandez wrote:

I fail to reproduce the issue. Which browser do you use? Or is this related to the "I have to press Enter" issue?

Version 84.0.4147.89

https://www.whatsmybrowser.org/b/J4PON

Same in Firefox.

Actions

Copy link

Updated by Anonymous over 4 years ago

File Untitled.png Untitled.png added

Ingo Fabbri wrote:

Andreas Fernandez wrote:

I fail to reproduce the issue. Which browser do you use? Or is this related to the "I have to press Enter" issue?

Version 84.0.4147.89

https://www.whatsmybrowser.org/b/J4PON

Just don't hit enter. Remove the characters to empty the field.

until it looks like in the attachment

I think you can't expect people to hit enter on an empty field, just to make it do a reset.

Actions

Copy link

Updated by Andreas Kienast over 4 years ago

So this is related to the issue I already created a patch for. Thanks, so I can link the issues.

Actions

Copy link

Updated by Andreas Kienast over 4 years ago

Related to Bug #91891: Page tree should auto filter added

Actions

Copy link

#10

Updated by Gerrit Code Review over 4 years ago

Status changed from Needs Feedback to Under Review

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65138

Actions

Copy link

#11

Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65140

Actions

Copy link

#12