Bug #91912

Exception when adding nested inline elements

Added by Andreas Kiessling 3 months ago. Updated 25 days ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2020-07-31
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
7.3
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

When configuring a powermail form, i got an exception trying to add a field with the "Create new record after this" button. The regular button that simply adds an element works like it should.
Since the exception only shows up with the button at record/inline level, i don't think, that it is a powermail bug

Conditions:
TYPO3 10.4.6
powermail: 8.1.2

Exception:

\TYPO3\CMS\Backend\Form\FormDataProvider\DatabaseRowInitializeNew::setDefaultsFromInlineRelations - viewable in the response of the ajax request

(1/1) #1444434102 UnexpectedValueException
An inlineChildChildUid is given for table tx_powermail_domain_model_field, but no foreign_selector in inlineParentConfig

Related issues

Related to TYPO3 Core - Bug #84867: Non admin-users aren't able to create IRRE records via the "+" Icon Resolved 2018-04-25
Related to TYPO3 Core - Bug #91863: Remove selected option with Closed 2020-07-24

Associated revisions

Revision a3645771 (diff)
Added by Nicole Cordes about 2 months ago

[BUGFIX] Ensure context for inline relation buttons

This patch ensures the correct context (previous child id)
is set on appending a new inline child after an existing one.

Resolves: #91912
Related: #91863
Releases: master, 10.4
Change-Id: Ie6159049d23059a5fce38637499217af5a0b25a9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65450
Tested-by: Christian Kuhn <>
Tested-by: TYPO3com <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Christian Kuhn <>
Reviewed-by: Anja Leichsenring <>

Revision 2c5ff528 (diff)
Added by Nicole Cordes about 2 months ago

[BUGFIX] Ensure context for inline relation buttons

This patch ensures the correct context (previous child id)
is set on appending a new inline child after an existing one.

Resolves: #91912
Related: #91863
Releases: master, 10.4
Change-Id: Ie6159049d23059a5fce38637499217af5a0b25a9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65454
Tested-by: TYPO3com <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Anja Leichsenring <>

History

#1 Updated by Stefan P 2 months ago

Can confirm for custom table that worked in v9.

#2 Updated by Webadmin no-lastname-given 2 months ago

Can confirm it for an own extension in 10 LTS too. So it's not powermail related

#3 Updated by Webadmin no-lastname-given 2 months ago

  • Related to Bug #84867: Non admin-users aren't able to create IRRE records via the "+" Icon added

#4 Updated by Emile Blume 2 months ago

I can confirm this bug after updating my environment to TYPO3 10.4.6. and Powermail 8.1.2.

Testing this in TYPO3 10.4.5 with Powermail 8.1.1 gave no errors.

#5 Updated by Christian Kuhn about 2 months ago

Confirmed.

Reproducible with ext:styleguide:

  • Styleguide data generation
  • Page "inline 1n"
  • List module
  • Edit record 1 of "Form engine - inline 1:n foreign field"
  • Click "+" ("Create new record after this record") Icon on child row "lipsum"

Works in v10.4.5
Broken in v10.4.6

Git bisect reveals patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/65098 which is issue #91863 as reason.

#6 Updated by Christian Kuhn about 2 months ago

  • Related to Bug #91863: Remove selected option with added

#7 Updated by Christian Kuhn about 2 months ago

  • Is Regression set to Yes

#8 Updated by Gerrit Code Review about 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65450

#9 Updated by Gerrit Code Review about 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65450

#10 Updated by Gerrit Code Review about 2 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65450

#11 Updated by Gerrit Code Review about 2 months ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65454

#12 Updated by Nicole Cordes about 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#13 Updated by Benni Mack 25 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF