Task #92689

Update @typo3/icons to v2 and support icon sprites

Added by Andreas Fernandez 11 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
Start date:
2020-10-23
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The npm package @typo3/icons added SVG sprites with the purpose to load fewer files and to reduce the overhead in DOM by rendering shadowed DOM.


Related issues

Related to TYPO3 Core - Bug #92793: Some icons are missing in the backendClosedOliver Bartsch2020-11-07

Actions
Related to TYPO3 Core - Bug #92860: Icon "warning-in-use" is missing since the icon updateClosedAndreas Fernandez2020-11-17

Actions
Related to TYPO3 Core - Bug #92893: SVG sprites are a breaking change, requiring CSP `default-src` to not be 'none'. Otherwise, icons are blocked in Firefox.New2020-11-20

Actions
Related to TYPO3 Core - Bug #92977: Dropdown arrows not shown in BEClosed2020-12-03

Actions
Related to Adminer - Bug #94129: Icons missing in TYPO3 v10.4.10+New2021-05-12

Actions
#1

Updated by Gerrit Code Review 11 months ago

  • Status changed from In Progress to Under Review

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66094

#2

Updated by Gerrit Code Review 11 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66094

#3

Updated by Gerrit Code Review 11 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66094

#4

Updated by Gerrit Code Review 11 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66094

#5

Updated by Andreas Fernandez 11 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#6

Updated by Gerrit Code Review 11 months ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66432

#7

Updated by Andreas Fernandez 11 months ago

  • Status changed from Under Review to Resolved
#8

Updated by Gerrit Code Review 11 months ago

  • Status changed from Resolved to Under Review
#9

Updated by Oliver Hader 11 months ago

  • Status changed from Under Review to Resolved
#10

Updated by Oliver Bartsch 11 months ago

  • Related to Bug #92793: Some icons are missing in the backend added
#11

Updated by Andreas Fernandez 10 months ago

  • Related to Bug #92860: Icon "warning-in-use" is missing since the icon update added
#12

Updated by Oliver Hader 10 months ago

  • Related to Bug #92893: SVG sprites are a breaking change, requiring CSP `default-src` to not be 'none'. Otherwise, icons are blocked in Firefox. added
#13

Updated by Robert Vock 10 months ago

Just a note: Moving images (in this case the SVG icons) to another location is always a breaking change, if any code uses the image directly (instead of using the iconIdentifier).

One of my backend modules lost its icon during the update from 10.4.9 to 10.4.10. This happened, because I was using a core SVG icon.

The documentation did not mention that I should be using iconIdentifier, that's why I used the complete path:
https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/BackendModules/BackendModuleApi/Index.html

#14

Updated by Johannes Schlier 10 months ago

Same here.
To avoid using the hardcoded path I rewrote my icon declaration to use an Alias (which seem like a great way to use core icons e.g. for doktype icons), only to find out those don't do anything yet.

Is there an ETA for this "Todo for a later patch"?

Update: Fixed it locally by changing 2 lines, but it'd still be nice to see the full functionality in the core.

#15

Updated by Oliver Hader 10 months ago

  • Related to Bug #92977: Dropdown arrows not shown in BE added
#16

Updated by Benni Mack 9 months ago

  • Status changed from Resolved to Closed
#17

Updated by Christian Weiske 4 months ago

  • Related to Bug #94129: Icons missing in TYPO3 v10.4.10+ added

Also available in: Atom PDF