Task #92689
closed
Update @typo3/icons to v2 and support icon sprites
100%
Description
The npm package @typo3/icons added SVG sprites with the purpose to load fewer files and to reduce the overhead in DOM by rendering shadowed DOM.
Updated by Gerrit Code Review about 4 years ago
- Status changed from In Progress to Under Review
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66094
Updated by Gerrit Code Review about 4 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66094
Updated by Gerrit Code Review about 4 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66094
Updated by Gerrit Code Review about 4 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66094
Updated by Andreas Fernandez about 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 2d6ed648ab87185e34eaa0c61c958840396584a1.
Updated by Gerrit Code Review about 4 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66432
Updated by Andreas Fernandez about 4 years ago
- Status changed from Under Review to Resolved
Applied in changeset 16024b88921f83aa919e57c3743b40957851f378.
Updated by Gerrit Code Review about 4 years ago
- Status changed from Resolved to Under Review
Updated by Oliver Hader about 4 years ago
- Status changed from Under Review to Resolved
Updated by Oliver Bartsch about 4 years ago
- Related to Bug #92793: Some icons are missing in the backend added
Updated by Andreas Kienast about 4 years ago
- Related to Bug #92860: Icon "warning-in-use" is missing since the icon update added
Updated by Oliver Hader about 4 years ago
- Related to Bug #92893: SVG sprites are a breaking change, requiring CSP `default-src` to not be 'none'. Otherwise, icons are blocked in Firefox. added
Updated by Robert Vock almost 4 years ago
Just a note: Moving images (in this case the SVG icons) to another location is always a breaking change, if any code uses the image directly (instead of using the iconIdentifier).
One of my backend modules lost its icon during the update from 10.4.9 to 10.4.10. This happened, because I was using a core SVG icon.
The documentation did not mention that I should be using iconIdentifier, that's why I used the complete path:
https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/BackendModules/BackendModuleApi/Index.html
Updated by Johannes Schlier almost 4 years ago
Same here.
To avoid using the hardcoded path I rewrote my icon declaration to use an Alias (which seem like a great way to use core icons e.g. for doktype icons), only to find out those don't do anything yet.
Is there an ETA for this "Todo for a later patch"?
Update: Fixed it locally by changing 2 lines, but it'd still be nice to see the full functionality in the core.
Updated by Oliver Hader almost 4 years ago
- Related to Bug #92977: Dropdown arrows not shown in BE added
Updated by Benni Mack almost 4 years ago
- Status changed from Resolved to Closed