Project

General

Profile

Actions

Task #94192

closed

Make the DateTimeConverter error for PropertyMappings translatable

Added by Bastian Stargazer over 3 years ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extbase
Target version:
-
Start date:
2021-05-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
7.4
Tags:
Complexity:
no-brainer
Sprint Focus:

Description

If a model holding a DateTime attribute and is filled by a form, currently the error-message for falsely entered values can not be translated because its hard-coded in Extbase's DateTimeConverter.php:169 ( Validation\Error('The date "%s" was not recognized (for format "%s").', 1307719788, [$dateAsString, $dateFormat]) )

The PropertyMapping for this attribute is configured in an initializeAction(), like:


// set input date-format for mapping the user.birthday property
$this->arguments->getArgument('user')->getPropertyMappingConfiguration()
  ->forProperty('birthday')->setTypeConverterOption(
    DateTimeConverter::class,
    DateTimeConverter::CONFIGURATION_DATE_FORMAT,
    'd.m.Y'
);

Input of "test" into the birthday form field resulting in The date "test" was not recognized (for format "d.m.Y"). as non translatable, where as all other messages are in the right locale.


Files

extbase-no-translation-available.png (19.1 KB) extbase-no-translation-available.png Bastian Stargazer, 2022-01-06 11:36
Actions #1

Updated by Bastian Stargazer almost 3 years ago

push - because its such a tiny change for a next release!

Actions #2

Updated by Mathias Schreiber over 2 years ago

  • Sprint Focus set to Remote Sprint
Actions #3

Updated by Susanne Moog over 2 years ago

  • Sprint Focus changed from Remote Sprint to On Location Sprint
Actions #4

Updated by Oliver Hader about 2 years ago

  • Sprint Focus deleted (On Location Sprint)
Actions #5

Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81933

Actions #6

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81933

Actions #7

Updated by Gerrit Code Review 5 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81933

Actions #8

Updated by Gerrit Code Review 5 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81933

Actions #9

Updated by Tim Weisenberger 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF