Bug #94402

Don't issue second HTTP request for error handling

Added by Larry Garfield 4 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2021-06-23
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

PageContentErrorHandler currently uses RequestFactory to send a new for-reals HTTP request for error pages. This is problematic for many reasons. cf https://github.com/pixelant/pxa_lpeh

A previous attempt to fix this issue in core for v10 (https://review.typo3.org/c/Packages/TYPO3.CMS/+/63389) was rolled back (https://review.typo3.org/c/Packages/TYPO3.CMS/+/63308/) because it resulted in infinite recursion in some edge cases. However, many of those edge cases have since been resolved anyway, so it's worth making another attempt.


Related issues

Related to TYPO3 Core - Bug #95174: pageNotFoundAction not working properly in Extbase with feature toggle subrequestPageErrors turned onClosed2021-09-10

Actions
Related to TYPO3 Core - Task #95253: Make in-process subrequests opt-inClosedLarry Garfield2021-09-16

Actions
Related to TYPO3 Core - Feature #88361: Site error handling: "Show content from page" for 404 should render page directlyAccepted2019-05-15

Actions
Related to TYPO3 Core - Bug #95586: PageNotFound handling doesn't work in debug modeResolvedGeorg Ringer2021-10-12

Actions
#1

Updated by Gerrit Code Review 4 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#2

Updated by Gerrit Code Review 4 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#3

Updated by Gerrit Code Review 4 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#4

Updated by Gerrit Code Review 4 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#5

Updated by Gerrit Code Review 4 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#6

Updated by Gerrit Code Review 4 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#7

Updated by Gerrit Code Review 4 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#8

Updated by Gerrit Code Review 4 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#9

Updated by Gerrit Code Review 4 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#10

Updated by Gerrit Code Review 4 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#11

Updated by Gerrit Code Review 4 months ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#12

Updated by Gerrit Code Review 3 months ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#13

Updated by Gerrit Code Review 3 months ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#14

Updated by Gerrit Code Review 3 months ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#15

Updated by Gerrit Code Review 3 months ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#16

Updated by Gerrit Code Review 3 months ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#17

Updated by Gerrit Code Review 3 months ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#18

Updated by Gerrit Code Review 3 months ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#19

Updated by Gerrit Code Review 3 months ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#20

Updated by Gerrit Code Review 3 months ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#21

Updated by Gerrit Code Review 2 months ago

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#22

Updated by Gerrit Code Review 2 months ago

Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#23

Updated by Gerrit Code Review about 2 months ago

Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#24

Updated by Gerrit Code Review about 2 months ago

Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#25

Updated by Gerrit Code Review about 2 months ago

Patch set 25 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#26

Updated by Gerrit Code Review about 2 months ago

Patch set 26 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#27

Updated by Gerrit Code Review about 2 months ago

Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#28

Updated by Gerrit Code Review about 2 months ago

Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

#29

Updated by Larry Garfield about 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#30

Updated by Benni Mack about 1 month ago

  • Status changed from Resolved to Closed
#31

Updated by Torben Hansen about 1 month ago

  • Related to Bug #95174: pageNotFoundAction not working properly in Extbase with feature toggle subrequestPageErrors turned on added
#32

Updated by Christian Kuhn about 1 month ago

  • Related to Task #95253: Make in-process subrequests opt-in added
#33

Updated by Benni Mack 12 days ago

  • Related to Feature #88361: Site error handling: "Show content from page" for 404 should render page directly added
#34

Updated by Christian Kuhn 7 days ago

  • Related to Bug #95586: PageNotFound handling doesn't work in debug mode added

Also available in: Atom PDF