Project

General

Profile

Actions

Bug #94402

closed

Don't issue second HTTP request for error handling

Added by Larry Garfield almost 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2021-06-23
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

PageContentErrorHandler currently uses RequestFactory to send a new for-reals HTTP request for error pages. This is problematic for many reasons. cf https://github.com/pixelant/pxa_lpeh

A previous attempt to fix this issue in core for v10 (https://review.typo3.org/c/Packages/TYPO3.CMS/+/63389) was rolled back (https://review.typo3.org/c/Packages/TYPO3.CMS/+/63308/) because it resulted in infinite recursion in some edge cases. However, many of those edge cases have since been resolved anyway, so it's worth making another attempt.


Related issues 7 (0 open7 closed)

Related to TYPO3 Core - Bug #95174: pageNotFoundAction not working properly in Extbase with feature toggle subrequestPageErrors turned onClosed2021-09-10

Actions
Related to TYPO3 Core - Task #95253: Make in-process subrequests opt-inClosedLarry Garfield2021-09-16

Actions
Related to TYPO3 Core - Feature #88361: Site error handling: "Show content from page" for 404 should render page directlyClosed2019-05-15

Actions
Related to TYPO3 Core - Bug #95586: PageNotFound handling doesn't work in debug modeClosedGeorg Ringer2021-10-12

Actions
Related to TYPO3 Core - Bug #95940: Error on random urls which should show 404 pageClosed2021-11-10

Actions
Related to TYPO3 Core - Task #98396: Enable internal subrequests for error pages by defaultClosed2022-09-21

Actions
Related to TYPO3 Core - Bug #103399: TYPO3 12.4.12 - PHP 8.3.3 – 404 Redirects in site handling not possible for external URLResolvedStefan Bürk2024-03-14

Actions
Actions #1

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #2

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #3

Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #4

Updated by Gerrit Code Review almost 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #5

Updated by Gerrit Code Review almost 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #6

Updated by Gerrit Code Review almost 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #7

Updated by Gerrit Code Review almost 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #8

Updated by Gerrit Code Review almost 3 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #9

Updated by Gerrit Code Review almost 3 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #10

Updated by Gerrit Code Review almost 3 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #11

Updated by Gerrit Code Review almost 3 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #12

Updated by Gerrit Code Review almost 3 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #13

Updated by Gerrit Code Review almost 3 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #14

Updated by Gerrit Code Review almost 3 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #15

Updated by Gerrit Code Review almost 3 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #16

Updated by Gerrit Code Review almost 3 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #17

Updated by Gerrit Code Review almost 3 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #18

Updated by Gerrit Code Review almost 3 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #19

Updated by Gerrit Code Review almost 3 years ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #20

Updated by Gerrit Code Review almost 3 years ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #21

Updated by Gerrit Code Review almost 3 years ago

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #22

Updated by Gerrit Code Review almost 3 years ago

Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #23

Updated by Gerrit Code Review almost 3 years ago

Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #24

Updated by Gerrit Code Review almost 3 years ago

Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #25

Updated by Gerrit Code Review over 2 years ago

Patch set 25 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #26

Updated by Gerrit Code Review over 2 years ago

Patch set 26 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #27

Updated by Gerrit Code Review over 2 years ago

Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #28

Updated by Gerrit Code Review over 2 years ago

Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547

Actions #29

Updated by Larry Garfield over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #30

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed
Actions #31

Updated by Torben Hansen over 2 years ago

  • Related to Bug #95174: pageNotFoundAction not working properly in Extbase with feature toggle subrequestPageErrors turned on added
Actions #32

Updated by Christian Kuhn over 2 years ago

  • Related to Task #95253: Make in-process subrequests opt-in added
Actions #33

Updated by Benni Mack over 2 years ago

  • Related to Feature #88361: Site error handling: "Show content from page" for 404 should render page directly added
Actions #34

Updated by Christian Kuhn over 2 years ago

  • Related to Bug #95586: PageNotFound handling doesn't work in debug mode added
Actions #35

Updated by Christian Kuhn over 2 years ago

  • Related to Bug #95940: Error on random urls which should show 404 page added
Actions #37

Updated by Christian Kuhn over 1 year ago

  • Related to Task #98396: Enable internal subrequests for error pages by default added
Actions #38

Updated by Stefan Bürk about 1 month ago

  • Related to Bug #103399: TYPO3 12.4.12 - PHP 8.3.3 – 404 Redirects in site handling not possible for external URL added
Actions

Also available in: Atom PDF