Bug #96796: Wrong addition to title in SearchController - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #96796

closed

Wrong addition to title in SearchController

Added by Gerhard Rupp almost 3 years ago. Updated about 2 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Indexed Search

Target version:

next-patchlevel

Start date:

2022-02-08

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

7.4

Tags:

Complexity:

easy

Is Regression:

Sprint Focus:

Description

Line 477 ff.

        if ($this->multiplePagesType($row['item_type'])) {
            $dat = json_decode($row['static_page_arguments'], true);
            $pp = explode('-', $dat['key']);
            if ($pp[0] != $pp[1]) {
                $resultData['titleaddition'] = ', ' . LocalizationUtility::translate('result.page', 'IndexedSearch') . ' ' . $dat['key'];
            } else {
                $resultData['titleaddition'] = ', ' . LocalizationUtility::translate('result.pages', 'IndexedSearch') . ' ' . $pp[0];
            }
        }

The else block should only be executed if static_page_arguments is not empty as the addition to the title makes no sense without any additional (page) information.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Oliver Hader almost 3 years ago

Related to Bug #96795: Localization Labels used in wrong order in SearchController added

Actions

Copy link

Updated by Oliver Hader almost 3 years ago

Is this a duplicate of #96795 or are both separate topics?

Actions

Copy link

Updated by Gerhard Rupp almost 3 years ago

Seperate topics on the same place.

Actions

Copy link

Updated by Shehfinaz Kadavil over 2 years ago

How can we test it?

Actions

Copy link

Updated by Shehfinaz Kadavil over 2 years ago

Status changed from New to Needs Feedback

Actions

Copy link

Updated by Gerhard Rupp over 2 years ago

Do some crawling of larger pdf documents (with multiple pages).
Check extension configuration of indexed search (basic.pdf_mode) to make sure that larger pdf documents are not indexed in one.
Check titles in search result page the suffix "page/s" makes no sense if there is no info about the page range.

f. e.

My pdf document title, pages 1-10

My pdf document title, pages

not OK

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Status changed from Needs Feedback to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74370

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74370

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74370

Actions

Copy link

#10

Updated by Stefan Bürk over 2 years ago

Status changed from Under Review to Needs Feedback

Just reviewed the patch Larry created out of this issue. In the end, I cannot reproduce this and also do not get what is meant with

static_page_arguments is not empty as the addition to the title makes no sense without any additional (page) information.

Taking comment in https://forge.typo3.org/issues/96796#note-6 I would assume, that it is about the fact that for "single" page result, it should use "page" instead of "pages" and additional state the page number.

Maybe you can provide a example PDF which produces this kind of "wrong" indexing / search result ? (please provide search word with the pdf).

Or is this eventually fixed along with #96795 ? (Even if it has been thought that it is a different issue?)

Actions

Copy link

#11

Updated by Gerrit Code Review over 2 years ago

Status changed from Needs Feedback to Under Review

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74370

Actions

Copy link

#12

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74938

Actions

Copy link

#13

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74939

Actions

Copy link

#14