Bug #96796
closed
Wrong addition to title in SearchController
Added by Gerhard Rupp over 2 years ago.
Updated almost 2 years ago.
Description
Line 477 ff.
if ($this->multiplePagesType($row['item_type'])) {
$dat = json_decode($row['static_page_arguments'], true);
$pp = explode('-', $dat['key']);
if ($pp[0] != $pp[1]) {
$resultData['titleaddition'] = ', ' . LocalizationUtility::translate('result.page', 'IndexedSearch') . ' ' . $dat['key'];
} else {
$resultData['titleaddition'] = ', ' . LocalizationUtility::translate('result.pages', 'IndexedSearch') . ' ' . $pp[0];
}
}
The else block should only be executed if static_page_arguments is not empty as the addition to the title makes no sense without any additional (page) information.
- Related to Bug #96795: Localization Labels used in wrong order in SearchController added
Is this a duplicate of #96795 or are both separate topics?
Seperate topics on the same place.
- Status changed from New to Needs Feedback
- Do some crawling of larger pdf documents (with multiple pages).
- Check extension configuration of indexed search (basic.pdf_mode) to make sure that larger pdf documents are not indexed in one.
- Check titles in search result page the suffix "page/s" makes no sense if there is no info about the page range.
f. e.
My pdf document title, pages 1-10
OK
My pdf document title, pages
not OK
- Status changed from Needs Feedback to Under Review
- Status changed from Under Review to Needs Feedback
Just reviewed the patch Larry created out of this issue. In the end, I cannot reproduce this and also do not get what is meant with
static_page_arguments is not empty as the addition to the title makes no sense without any additional (page) information.
Taking comment in https://forge.typo3.org/issues/96796#note-6 I would assume, that it is about the fact that for "single" page result, it should use "page" instead of "pages" and additional state the page number.
Maybe you can provide a example PDF which produces this kind of "wrong" indexing / search result ? (please provide search word with the pdf).
Or is this eventually fixed along with #96795 ? (Even if it has been thought that it is a different issue?)
- Status changed from Needs Feedback to Under Review
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
- Status changed from Resolved to Closed
Also available in: Atom
PDF