Project

General

Profile

Actions

Bug #97763

open

Translation Button shown eventhough already translated

Added by Nikita Hovratov almost 2 years ago. Updated 24 days ago.

Status:
Under Review
Priority:
Must have
Assignee:
Category:
Localization
Target version:
-
Start date:
2022-06-13
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If content of a page is translated, but not the default language is chosen for the translation source, the localization button is still shown.

How to reproduce:
1. Create 2 additional languages
2. Have a page and add a content element in the default language
3. Translate it to the first language
4. Now, translate the third language, but choose the second language as translation source.
5. The translation button is still shown.
6. If you click on that button again it will skip the steps of the translation wizard and stay stuck in the last step showing just the spinner

Code hint:

It seems the new Page Module only considers the default language to unset the already translated records:

TYPO3\CMS\Backend\View\BackendLayout\ContentFetcher:179

                if ((int)$contentElement['l10n_source'] > 0) {
                    unset($untranslatedRecordUids[(int)$contentElement['l10n_source']]);
                }

The old PageLayoutView(L:1418) handled it differently:

                foreach ($records as $record) {
                    $key = array_search($record['l10n_source'], $defaultLanguageUids);
                    if ($key !== false) {
                        unset($defaultLanguageUids[$key]);
                    }
                }


Files

translation-button.png (38.1 KB) translation-button.png Nikita Hovratov, 2022-06-13 10:49

Related issues 4 (3 open1 closed)

Related to TYPO3 Core - Bug #98172: Translate button still appearing despite all content elements being connected, page being in Connected ModeNeeds Feedback2022-08-18

Actions
Related to TYPO3 Core - Story #101564: User Interface related translation issuesNew2023-08-03

Actions
Has duplicate TYPO3 Core - Bug #94397: Translation Button is shown in connected mode if l10n_source differs from l18n_parentClosed2021-06-22

Actions
Has duplicate TYPO3 Core - Bug #98172: Translate button still appearing despite all content elements being connected, page being in Connected ModeNeeds Feedback2022-08-18

Actions
Actions

Also available in: Atom PDF