Project

General

Profile

Actions

Bug #14927

closed

Fileicon-Path is hardcoded and not changeable for the Frontend

Added by Arne Bippes over 18 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
Content Rendering
Target version:
-
Start date:
2005-08-16
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
3.8.0
PHP Version:
4
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The icon-directory for the filelink-property is hardcoded in the source (t3lib/gfx/fileicons/). The Backend is configurable using TBE_STYLES. Something similar is needed for the frontend.

The appended patch for class.tslib_content.php uses the TBE_STYLES code from class.t3lib_iconworks.php. It reads new TypoScript propertys:

filelink.icon.iconAutoCfg {
forceFileExtension = png // alternative file-extension to look for (default is gif)
absDir = /srv/www/typo3/fileadmin/icons/ // Absolute path to the directory with the icons
relDir = fileadmin/icons/ // Relative path to the directory with the icons
}

(issue imported from #M1378)


Files

bug_1378.diff (691 Bytes) bug_1378.diff Administrator Admin, 2007-04-26 18:08
class.tslib_content.php.diff (604 Bytes) class.tslib_content.php.diff Administrator Admin, 2007-04-28 21:05

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #15700: Wrong hardcoded path to fileicons in class.tslib_content.phpClosedKarsten Dambekalns2006-02-22

Actions
Actions #1

Updated by Franz Koch about 17 years ago

will this bug ever be fixed? It's only a few lines of code but really anoying :(
Could easily be included for 4.1 ;)

maybe like a global constant that is automatically pased to ->filelink.iconPath and can be overridden within each instance of ->filelink

Actions #2

Updated by Sebastian Busch about 17 years ago

i vote for this bug entry

this would allow us to secure /typo3 via http authentication, thus blocking script kiddies trying to exploit bugs in /typo3 scripts

(ok, there a no such bugs known YET)

Actions #3

Updated by Michael Stucki almost 17 years ago

There is a property called iconCObject that will enable you to create your own icons however you like.

Example

iconCObject = CASE
iconCObject { # look at TSref to see how you can do it
}

Actions #4

Updated by Michael Stucki almost 17 years ago

Many thanks Joey for this worthful contribution! :-)

(for those wondering what this means: We used this bug report at T3DD07 to demonstrate how fixing bugs works...)

Actions #5

Updated by Michael Stucki almost 17 years ago

Fix is under way...

Actions #6

Updated by Christopher Hlubek over 16 years ago

+1 for fix

Actions #7

Updated by Ben van 't Ende over 16 years ago

is this fixed now for 4.2? filelinks will be taken care of in 4.2 if i am correct

Actions #8

Updated by Christian Kuhn about 15 years ago

I think this is fixed.

Best reference is svn revision change from 1420 to 1421 which changed the important lines mentioned in class.tslib_content.php.diff nearly exactly as proposed.

Actions #9

Updated by Michael Stucki about 15 years ago

Seems fixed. If not, please reopen.

Actions #10

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF