Bug #17065
closed
Impossible to delete version from Live Workspace !
0%
Description
Hello,
I am admin, so if I want to delete version in Live Workspace (from custom workspace), record has not deleted !! Confirmation message is OK, but version appear again in Live Workspace ! I must to delete it manually in database.
Thank You
(issue imported from #M5108)
Files
Updated by Simon Apold over 13 years ago
I agree, that the "delete from workspace" doesn't work as expected.
The record-version isn't deleted but moved to the live workspace.
This issue is located in the method tx_Workspaces_ExtDirect_ActionHandler->deleteSingleRecord().
Instead of calling action "clearWSID" it should be "flush".
It would be nice, if a team member could explain the idea behind this behaviour.
Updated by Sonja Schubert over 13 years ago
- Category deleted (
Miscellaneous) - Target version deleted (
0)
Hi Simon
Thank your for your comment and interest. We talked about this issue in our workspace team meeting today and came to the following result.
In our opinion, calling the action "clearWSID" is correct, as we do not want to flush the record-version completely from the database but want to just set it to deleted=1. At the moment it may be the same, but we want to improve the history management in workspace in future and therefore we need also the "old" record-versions.
With the trash button in the workspace module you can delete the record-version so it is deleted=1 in the database. After pressing the button, the record is in workspace the same as in live again.
If the button does not work for your correctly please give us more exact information. Which TYPO3 version do you use? What kind of record did you change in workspace? tt_content or something else? Did you get an error message or what happend exactly? When you say the record "is moved to the live workspace" how did that look? Do you mean in live workspace in the backend module or in frontend?
Thank you for your help.
Kind regards,
Sonja
Updated by Simon Apold over 13 years ago
- File patch.diff patch.diff added
Hi Sonja,
thanks for your answer!
I see the argument related to history management. Instead of flushing the version record the right command should be "delete". The record will be marked as deleted but it will stay in the right workspace.
The command "clearWSID" does NOT set the "deleted" field to "1". It just sets the field "t3ver_wsid" to "0". After clicking the trash button in the workspace module, the version record disappears from the currently selected workspace but it is moved to the live workspace as an offline version. It appears in two places in the backend: in the workspace module (live workspace) and in the list module's versioning view.
I attached a patch file for testing purpose. I just changed the command, which is called after clicking the trash button in the workspace module, from "['version']['clearWSID']" to "['delete']".
Regards
Simon
Updated by Michael Stucki almost 11 years ago
- Project changed from 624 to TYPO3 Core
- Category changed from Workspaces to Workspaces
Updated by
Updated by Benni Mack about 9 years ago
- Target version changed from 7.5 to 7 LTS
Updated by Oliver Hader almost 9 years ago
- Is Regression set to No
For the old versioning stuff, the clearWSID and flush commands are just fine.
Working on a workspace means that these elements are encapsulated there.
Thus, I agree that "discarding changes" should not create offline versions instead.
Updated by Riccardo De Contardi over 7 years ago
- Status changed from Accepted to Closed
I performed a test with both 7.6.18 and the latest 9.0.0 master:
My test:
1) switch to custom workspace
2) create a content element in the workspace
3) workspace module > click on "discard workspace version of record"
Results¶
1) the record is not listed in the workspace module > LIVE workspace
2) the record is in the recycler
I think this is sufficient to close this issue as no "offline" version has been created (the record goes directly to the recycler)
If you think that this is the wrong decision or have a more complete test that should be performed, please reopen it (or open a new issue with a reference to this one).
Thank you