Bug #17095
closedTypolink : cHash isn't created if there's no additionalParams
0%
Description
If the typolink is configured without additionalParams and without addQueryString, the cHash is not generated, even if we need it because of linkVars
File class.tslib_content.php, line 5219 :
if (substr($addQueryParams,0,1)!='&') {
$addQueryParams = '';
} elseif ($conf['useCacheHash']) {
$pA = t3lib_div::cHashParams($GLOBALS['TSFE']->linkVars.$addQueryParams);
$addQueryParams.= '&cHash='.t3lib_div::shortMD5(serialize($pA));
}
I propose this patch :
if (substr($addQueryParams,0,1)!='&') {
$addQueryParams = '';
}
if ($conf['useCacheHash'] && trim($GLOBALS['TSFE']->linkVars.$addQueryParams)) {
$pA = t3lib_div::cHashParams($GLOBALS['TSFE']->linkVars.$addQueryParams);
$addQueryParams.= '&cHash='.t3lib_div::shortMD5(serialize($pA));
}
(issue imported from #M5161)
Files
Updated by Popy no-lastname-given over 17 years ago
Patch file also resolve bug #0005117
Updated by Popy no-lastname-given over 17 years ago
Did somebody read the patch and test it ?
Updated by Sareen Millet almost 17 years ago
Hey Popy,
I did test the patch and it really helps some problem. But in the new Typo 4.15 again the cache is confusing and there must be some more bugs. - proper caching seams to be relly tough.
Sareen
Updated by Popy no-lastname-given over 15 years ago
Bug still exists in 4.2.6
It is sad that core source code is breaking my cache :/
Updated by Rik Willems about 15 years ago
Hi Popy,
While searching for this problem I read your issue. Soon I found the following in the typoscript documentation that at least solved my problem:
typolink.useCacheHash = 1
Greets!
Updated by Popy no-lastname-given over 14 years ago
Reminder : Bug still present in latests releases (v4.1, 4.2, 4.3).
I can build new pacth file if needed and if it has a chance to be taken in account.
Updated by Popy no-lastname-given about 14 years ago
Sorry, wasn't looking the good svn repository...
Updated by Jo Hasenau almost 14 years ago
So is it still valid or can it be closed?
Updated by Ernesto Baschny almost 14 years ago
No further feedback, so I consider it as closed.